PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Simulating "Tukohama, War's Herald" prevents Fist of War from supporting skills granted by items.

Open
#10,310 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

How is Path of Building expected to behave?

Unallocated Tukohama, War's Herald skill should not impact stats.

How does Path of Building behave?

If a body armor socketed group exists and fist of war is socketed in a different item to support a slam granted by that item, OR, if another skill is socketed in the body armor alongside fist of war supporting a skill granted by that body armour, then simulating "Tukohama, War's Herald" in any way (e.g. hovering over it or using show node power) will disable fist of war from supporting that skill and persists until PoB is restarted.

How to reproduce the issue
  1. Equip an item other than body armor that grants a slam skill e.g. Facebreaker with Doryani's Touch.
  2. Add a socket group to body armor
  3. Add a socket group to the equipped item with fist of war - note that fist of war will increase damage as expected
  4. Hover over "Tukohama, War's Herald"
  5. Any change to the build e.g. allocating any passive will now disable Fist of War from supporting the item's skill.

This also works in body armors but seems to require another skill to be socketed.

  1. Equip a body armor that grants a slam skill
  2. Add a socket group to body armor with Fist of War and any other skill
  3. Hover over "Tukohama, War's Herald"
  4. Any change to the build e.g. allocating any passive will now disable Fist of War from supporting the item's skill.
PoB for PoE1 build code
Simplest example I can make:
eNq9XG1v2zgS_lz_CsHAHu5wTWzLL3Fyzi6cOG9A0njjpL37VDASbXNDiV6JSuIt-t9vhpRkya9U5Lsu0NrUPM-Qw5cZjkfb--3d49YrDUIm_NNq47BetajvCJf5k9Pq0-PlQbf626-V3pDI6f34LGIcn_xa-dRTny1OXykHXNV6ZfTtTrj0tHpzN7x_eKxazpQExJE0uEWhfiSFfi6DiFYtSYIJlV8Tzc3voHlGfDmlwr8jf4jgSrin1S_Cp5l25ufaPcL8kXBeqLwKRDQ7rdpV65n4LpOJBAkd6rvnnIThF-LRpNlZNIwc0F-FEX3qDTmZ02AkibRC-Ou02gfDkAkdEA_-hiESHgHCbhwetau1rZCzKAhlEdxoRqmbitYPu61NksOAXozH1JHslZ4HTJ5Pie8stNQ34YrK3kVcshlnNEjlG4fdTYjrFfJGfSP9o5CED4ajhWz30D7aLi3k7m5_Y3J6xsGQxtyIuJn4TNJCkKFgofALjyAL2Gz7iHPYY0ayDzSkwSuRLN-ZzdzCe2Z-AfvcEZ-ci3Bh-0Zrm-iQBrDfZA5R3wEYUUfAFs0pgZ3SMdCzHr1R4S0bU3PJQmOJAUV787FxXIxM5QoTf6xDD3DMmUmORMQNJeXi3LG3bIA_s4KNRmOT5IC-m_FlBTev9htfmtFlBTfTDeirwF282y7qLLm4HqaSrfZhu9lot7vH7WbdPt7oNqbzkDmE35F35kUenNeP5IUuFB41Ni_UyVT6cCRtgrY2DuuSBbQ46lxw9wOoKRHhJlizu_k4Yf41xAx9x4kgXJkvNG3dualYp77FpTsnKHvjO2bHwZMfqAM9Ewl0tgIeYJNiwPHMqSFioSLe6ib-WquaUD_WNzcbzi2lzvQK7PtAJDXzB6lUe7tZUdbIrCi4xqxtQ0ABIyFwg5EOj7eBCprpwqfBZD6aMsrdzMFnIp707JzMDJDK0Fm4kcHz-gqtmSy0oFG-kcA181NF-_RKwuy53GluN5cWN1uaFEJVALjUNCwfBuIPDPx5MVg_8EQUGLhcHIEWNhpA4lL0PeeBupFj5sPS-8sZh9ub6TBSFPST80LQvpTEeRkId2JsNKWkECLfv1E0m8EpgqvBlAC9JUT0LBMeHXQMpO9hKWe3dH2bYzVXsJA2VpCGCuZaliDmY0F3X2AwC3FjFemE3sFh4YEbUJf0O5E5djdODlzijG5kStDwZjgUb9DzKSZOwmLSEBYtQqGNXQmo_9fcmD8nbqTgwnchxIKtYKxjGbFOzSPz4CANwwGRxHLjOPorCRjxZUOlppYabdUYUhI401tYD6fV7LdLwvkzHBbQivy9mkp04acbSb3QImpF4OcRlYopCqm-LH2jZCZ81ewzDqRT8YaDGTBYSGAth4Zx9kt1HDks5iIHfv_0AN2T8xPr6cvN708XlUvi0OeAQhgbVOCOQ2Yz6lp3TMqwEnuZE6vVST6fkTC5TYJ7OLHqh91u97iiXaqlfeqJ1WhUsk52GdSoqD6pfN2J1a1Xfo8IV32y6xWdaAtPrG_w39XBVUWJwQ0HcJ3KjTfjzGH4vFH58UpDySaM8J8_Ij8EF4ER6s8rmEoZanpgtAYimBOf_Q2sFv4rtB5F5Eyt0QvjvPJDkkl44irH8tkBu6Cf-fnPZv0XSwrriotnwq3zuN0C87AXai0yVpUGCAbokMBmMGIPTCAj33qcwpE8hXMtr2AWO7LPRPmJnz-goxN6AjZstn_-vVOvH0DcV__HL5YnAmolbs_Sfs96Y3JqPfkk8HCC0Klb2t-ElezoL95hEq0JMOBk9-AYeUAtltKlUn7VeDWodb1Fwt4p0dwi0WxrmdZOliRZWcNVkS5ZWN9xPzeufM074gIkATF8fnq4xV3mq4zrJSfhi4W9gGc3brr9dyEahRF2YUSzMKJVAKHNVGggfS_iVBYAXFPuFQLEnSpiqzPhzq0kqjRGwa59xUM_ATR2qxEyLKDgAaKIQsZVALsooMgaOaP8A3PRsEZvGKAUnsOiODiRx7KQyTTC_uiYrP7zPAzxyFbepJDqrUR761FzX0StfRG190XU-QjRPiZsH3O1j2naxwztY3LKz4u9r91k72s32fvaTfa-dpO9r91k72s32XuZsH3M1T6maR8ztI_JKTEvOlgqMyvrGezSDM3SDK3SDO3SDJ2PBZVlJmQLjb0fmuZ-aFr7oWnvh6ZTOJAvM0nrGezSDM3SDK3SDO3SDMV2DdyRyu2XNQR2WYJmWYJWWYJ2WYJOwWteqUlYg7dL4psl8a2S-HZJ_Kr9dSJqRKXKy6p0LH46J9wJdXrKn0WYOg5U9eLF5eXF-ePN14tEi8dC5_tzNB5jHWJMqSF-5D3TQOW0tGiIWcjvujmWHFH165bKfakk5YhyaKpaYfQc6men1a-MvqmHAyoJ42HVcgTnZBZSQI0JD-katmuWlgpmuRRP5pkB0zcSOAHDJEuW6OKdBhJMsnhqQDUkjlzm8Wb4mwJ11Q9cZjSqbm9lVHpI-BMsZu-NiOICySyVzrKek1DqH4kNWDBlnCfBFrOh3HgzwpfmKGkzGQAO_HE-o_iTQLjGKBKehTPqsDFzYhmzxZP8vpizTVrOYsChaibz-LjJZKGoWsg8Omkzsaqqvlyyatxmsr6oQ-Z5dNxkAE6LDPIEabPwr3G5GDBdcNpnHH8jXJrZL8JXix2230LAgPAOzir9--MS4b2c0iB9YsAEuyRgz5FcPhWy7Sa2UkVPOTOpFpOxqMKeLFS3mNg1V-ySO4xyT8zOxiUK3WIATX5mzoJ1m-EUxKnynPnjNhMjJDUoufEnjSabRB23_VfB3NWTYuVhWUJVmbGHfmHtRXma5WIMI0b1087SfknaPgh_kgx_Sl3Don4RNiPBLVeOAXdeOYZH5jsyCqgRwcNKVPOwHMtsQKY1AjlnnTR-EJ_WE3yYQVc9fBiuijJM0Hj-D-hYFQ2scQCLR4a-ZD3XpYDAEMINIk13xmYu_IF9ANbdA5Ua4voT6WPmil3vWqttYNSHSlxFvHpexg-MT6dNRBAXXJsGoBuZ0kKla0o4vp0ieDnClTLqMmRYbBnNiO8mdPfr4v7C0wBXduBU1TkDrOksa0OsEllDlParV0sumr0vAqImpMbW5EtvSAKJpTbire--4sJ9hHkIk65YLtbE-CT2_hxmCEt6_Fxfe48BpXGJEVZjJrVBPfyi31rT92HLg1sPDeZxIKhu0nCphQ_tbrfZxDfcIhS4JuEUNrlHFm_a2VVLgpbMm3f2MRZAYR0HCeb9xRtzqEoVMpF8Wz0u8IArvPrwaSrlLDyp1d7e3g5nRE7FmL4zTg8d4dVmAILRHKgb9QFqrvXhz9mkr_4oolrC1IuLjOJ0AS6UgMGw4us_WkHNBJopMRdeueP6rZEM0BJ_CeHd6hcTj7ZVYSnBf4ON28edw_bRUUe3_Oe0etA9bhzaR_HLBj11PQsV0y2dwK3qinrZiR2TiEtoi5X6aPDkRYvs87icSk1gPMk6kaALyUI4jZH5bD4YjpI-5hovMdpdeo1LjQ_iGy2HF0zoWv_2Nl44sYJsoZlutMCP88ilN35crBhPNr5U2V90Ti36-BEnzzg-fEUUS5qS3bEMScrfuJD5WpFaVn0ILQ6-Liqpd9I4yZS7fbby9W7V_2VXG0lH4_IUvaJ7YMoYqovNGglBttFOlOl5t2Fa1TK_UYkPVdwWqqo2nVbSO3pd1VvV-jOzNJa6DKenHxdWxQasqb7__-dy1USvuqQSBxyvwUu4FYkxXK2qRvbTjesMuMq3sCE2WmJsqeaJThLeUUlcIolODNZwz9QW-wIR95pmt6kbq4aOPybJR30iqKpQDzVY9B3_US4gd6CfC3_MJvFu11_i7a5Y05bc_hxy2AxYpkiDNDV5VE9yk1R5Kl1zD35K1e4lHV6HbKXIWfr-wADMoWKrLbg0GQouzXkZqYrGrfLtNNGaFmLiy7IqY6gydWjdEeVjI60hmzB-P1YRM8AxlDaBLXRfE87FGwRYcIvxqO7_A_VgCbtnc3DA8218zZy1sRR-CBHDFkD3uJOHYMF5nLrdAmvnpzXzCsAWkG23GjlYWkS_W-FiVh2hXOauaW3WV8e1u4tH9TxMp2-3GSKvZfGyeoGuBWmy3NzimXcizEHL7zlsWxetPBJPukJzm3_LpuAeUFFtfiMUUo7W2a14BYbLeDesm2AIpr3heL6NfPAnofpnGEBcrd8nMlk1jj5IkScg_JFNaKCOG_M9ns7pro2-rdd6PexctyvG2qGz0zjuHudA-Yhq7WqoN1p5RUnK0OwMx0J2EzfRXrbHSHC0x0jXvrv5E-YcriXCuxMuG8PyVKlCSzLJKebtVZy87JR1tKHd8Rq0ds6pH9UXNfXt10qvtvz_Lfkvm-sZ1A==
Screenshots

Fist of War accurately supporting item skill:

Image

Hovering over Tukohama, War's Herald:

Image

Hovering over any other skill to show that Fist of War is disabled and will affect future calculations:

Image

Fist of War now disabled:

Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by importing the provided PoB build and reproducing the change after hovering over Tukohama, War's Herald. Trace the calculation path for Fist of War supporting item-granted slam skills, including socket groups and passive changes. Done means simulating the unallocated node no longer disables Fist of War or changes later calculations.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.