PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Sacrifice support not using totem life when used by totems
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
- I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?
Windows
What is the value from the calculation in-game?
The totem sacrifices its own health, I think the damage is calculated based on that. I am not sure about this, I have not done any testing to verify.
What is the value from the calculation in Path of Building?
The value in PoB is calculated with the player's life I believe. I think it should be the totem's life.
How to reproduce the issue
Use sacrifice support on a totem skill.
The calculation is not correct I believe.
PoB for PoE1 build code
https://pobb.in/hVP-LRdejy8Q
Screenshots
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with the linked PoB build and a totem skill using Sacrifice Support. Trace the calculation that determines Sacrifice damage and compare the value based on the totem's life with the player's life; it is done when the calculation uses the correct source and the reproduced case matches in-game behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100