PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Tempered by War not credited in Calcs under Source Name

Open
#10,247 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: accuracy
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

What is the wording in-game?

Tempered by War provides:
50% of Cold and Lightning Damage taken as Fire Damage
50% less Cold Resistance
50% less Lightning Resistance

What is the wording in Path of Building?

Under Calcs, it doesn't show as the +50% Lightning Damage Taken As Fire Source Name . It also doesn't show in the Cold and Lightning Resistances Source Name

PoB for PoE1 build code
https://pobb.in/kOXu-99xHr7w
Screenshots
Image Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by importing the linked PoE1 build code and opening the Calcs view to reproduce the missing Source Name entries. Trace the Calcs display path for Tempered by War and compare the damage-taken and resistance sections. Done means both 50% damage conversions and both reduced resistances identify Tempered by War as their source.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
desktop, game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.