PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Cost efficiency applies to soul cost of vaal skills

Open
#10,220 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: behaviour
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the behaviour in-game?

Didn't check ingame, but the wiki states:

While the soul requirement has been referred to as a 'Soul Cost' historically, and still is on Shepherd of Souls, it is not a cost in the general sense, and is unaffected by generic cost modifiers such as Fanaticism or Tireless.

What is the behaviour in Path of Building?

Generic cost efficiency affects soul cost.

How to reproduce the issue
  1. Add any vaal skill
  2. Add the custom modifier 100% increased cost efficiency in the config tab
  3. Verify that the soul cost decreases
PoB for PoE1 build code
eNqtW91z2roSf27_Cg8z97EhQKDkDOkZQj5nkoYLtL33qSNsATqVLY4tJ-H89WdXso0NmErYfWhB3v3th1a7qzUd_Pnuc-eVhhETwVWjdXbecGjgCo8Fy6vGt9ndp37jzy8fB2MiVy-L65hxfPLl44eB-uzMSeAxedX4KgLacHzCgqlwf1F5H4p4DXgN55XRt2fh0avG4_P4ZTJrOJy-Ug7PzkGWJOGSyu-p_M5PWCORSwNvxEkUfSU-TcHXJJArKoJn8pcI74W3t86Cwrq7IiFxJQ2fUN4wlkKrsSA8wsdb_KkLwhtg1IfBmJMNDaeSSCeCv64aQ_ANWdIHJsEUwmMgb3X73bNev9toHmW5jsNI3hAfPhqzTteUelvqs4t2v_u5lfxdxjQO6e1iQV3JXukoZHK0IoG7ldkr47OlfY65ZGvOaJjTsNSUhz1w3PAS4pmQhN-Mpxltu93rnrV7ieWd43xiuzelEn4wubrm4N0TpCDv4zJgkp7IPBYsEkEF-_KspSaOYs7hcBrRTmhEw1ciWVGtcmzhz1lwkveeSUBGIjLYI6Qc0xBOv7RimFJXQMKwlWHJ-cQW1JzSyo6EwVab0-y4nZrSWQOfptAEMqQZ5VTEvEDZapcnoKnc5ql2KeQNfTegegykAdWE_p0nbHW75VJfBZ6935usMsDtwzij7Ld7Z_3L1ufeZa_X6vRLi8JqEzGX8GfyzvzYh2w8I79okPPcRb88tpYrGUAqKWP-3CstFHcspCewjQT3TmFbERGV8vWPnh4jV0BBdv9A6sfANTuU34JQ5dZ8HT_q6wWdwGHBnmHOqTHPVkxy6EzKrBa2pEEicWNm0hOl7uoeersJkdQsxW47iouLo75FYiPfIuEB3x7BL3JYuAkZD7up1To7WucsPXUb0HC5ma4Y5Z4ddarZiKwN0iY6Os9t5PCiOKugybNauuQHCT2zkmGr0yuJ8hm31TvuLk1uFpoUGktg8OhOx3te3rKLv7Bh53Zsw9AXcWi44ZrYyIC0WOjbyoR6sWtWnbJ7xzWHa5-pGRkX6Mm5FetQSuL-uhHe0thpSogVR1G_abxeQxLBaDAFwCIIHTbLdSqfegbULxDKRicay6W5gC21sYCsBTCXssNibgvWcAtjtuTGIrINfYZk4UMVUPfsZ5Er0aWbA5cqoxuSIjS8qY3FG2i-wtlHZEcNvU7GUFqJ7kIa_LMxxi-QGwm4Dbw4xKNgLGOX45CYGfMhkUbRDZHE8ZIO-TsJGQlkS82SdhbbajGiJHRXTxAPd4TzOaSHq0Z-Fb4h_qCpJlb4aRZS6pD0hLuIohTAL47L40jS8IFEqzsR-mQ7nGoXRlOPHprrBMKj0VWj2-93OjgAQ96NjrdI64EXIRJuhkXWgPGGI0GR3OyrfZmMpTQ26vRh8G3ypD58WEm5jv5oNt_e3s7WRK7Egr5DATlzhd9cAxNY8yn6xTj_hLDNIfy5Xg7VHwXUTJEGekQXNfU3PEUhAyv0LjTRC8pf6Cb8MEXQCJy_IDGX99R_0gO8AN2TXjDAUhHiw-h6A2fgDkv_ztggWom3J7ok7gbJskHcFve_MeFMbtQVS1Fj6tWos80a3Tx8etoRdNWQYQwoyXaiqlMqt1uaLDjMS9eSRYcG2HB7KQALYOc96POTE59sEY40h1tsFXGczNH-vYcjwt0oE_NhAEomUu65mBPeSmUFxE8i7zsh3BmGbqNA2E4Jk1Ep-mNJfQyLZyqJBwek-SjBBU30Q1MJh08IprBcEQdSHw58hHzZs7_zTn7VB6lAUPRLEiRaRhIgiU9VkOjgwI8jESzYMtkI_SW_E9lKYSsgUbh0BfWJhsorVw0_mzLi5IyG1JtiyR-hSVPKF-C92J_TEO_XqXb7KK6WBj6WIeEztoQMighb7iPMmIboDaQOXe1N5NGA-ptiG7VlbLcvWuWsEVsy_rJQWR5MVek0E_kbidg62EnbuvcBsqV4g3p9xzEc0clQV32okN71Zsj5xlwNbDDGePNOGTrlDOus9d338MV5Od_UFZDQtZrmmqUdc0rfa132Lw2camqNYsiuFplW59k8tJQpa5esRCUvCFLyz-fnv9uafHeVSTHi2g2s_mXPIA52ZXXPTYLxFtmLEWkRfiGTu8r-3sTc2w-DnJBFho19xY22O6hFXhup0xXUd9uDomp6bq8vDLb6BIOSG6bgfEKCPO_nzKAR9F_Ch-acLSAw1O1wt1ZLJjnFKarqHJJy2zo__w9W8ZCSiHpQAyPp0MWCuYwG7kZXsQPYuqZl1UkVNf0tbRW_M_rm_COE_z_V8eGn_6tPqkWB9vaGQb8HTbSLLYrWULefUxlim4AcSc-kz_fg0ce-xqHv-M-YhFiPdTukHqtGQin2GKxjmZ4WFrk_5_Fige8xQYQM1Uva27u729Hs8ftt0kbnWVT5_6l9vBcLgylV13xVkJOizmEJoON5pJ9BXwDWq4c30HkwHmF3wTlZR7gdW52LaA_bA5nHUji5ZwZIP8CPIcOamAe6faehBOu3Tw2gxtCa7OLAPrypHgNv-mYw6nXjnlXaJJxF4TXGCCjJ5XkoPd4YwS1CT8sMUDCPFUFwxcwUCEPCd_YoXTMxAA3HzhwPQXTAKRK7dujB4LS5CY1Z8KSJueAb14UrpLsxwlCveov8yZJJoKjXtUXudM3Eq-pV8Y5XkzWT-KIu2RS5kyUD5mzaWgTIlkWgfslggHTL6ZBxHJbs7OxXEahgh-O3JTAAfIb0lVyMi4Av2OZnTwyQ4JSEbB7L3ayQXzfxlXoJVHCTWjGxRb3iyLPqFRO_Fmb-hWRUeGKWG3cg9IoBa9pP5Jn1muEWJH11wf3JmokT0o65YH-6aHJIVLodvgrm7WeKvYdVAVWjUINeOISuDrM7lTZChJY6-rVzXtK1E9m_wSWOyc0BlO3k4LcgeOSqIeDJq4Ywg65RxiE1ApjsdTWT3V6mhDMblhaKdbp4In82WD0ZQY9_T2ZXcwsTbsz_0LGrNvlAAdg-Mqwlh7HuoKHGdoNI05NRjjWVcXAD3q0BSpl4OCOd5q6k9B70WgmiTirJbyT282XywDg7lQFBX_Bg2oCWImVvbB4o4fgDOsGrAe79SKQKGL51jtck8FK4l0N9v_U2CBkBpnpNcYMvt6v6UF2494EyveCim1w0B-oO6pD1mgZebjIfwSWLJNWdww5M4cY79F4xhmewJVHh1vpVQOeF6iFy-mWg5tTHrsp6YIxkybjYiSOqfz_2g5K1CNQyDuP19VYTJlPko7TgJy6AUurR-XkjuRVrUqftTN_I2hnON1FEuKPfiji9hmIYz79NnpJXR6VADxQOodxF6FogXFO-x9-y4RfextGN1y5Mpx6YtgWMKq5W-h_24EVlBBvjs3CooEUZRqeyJTVFQ88yKC3I70OysNOzzFvtUzDwEFvwDf2YU3maU-vZihPiqnUwVdkE1z0XrzSqJcQPqdI9wSbro3GCstYeqmtvbDw7gZbJyh2KoW3L0KlYlzqn-Kb2kK0jz_Qqa1G1xl9YpRJoDOs4cAcDtV3ZF-26VKneevXqUqXq_vZqOCs96xpcfS9rahpbddWVOk571_as1SCzpq6tahjaN-_dyiHUq5raWtZKt6uKrK0P6lTVpF1D4mjVgFG5QHXqSsW15ZI6XNutS5nqV9yTy27Vne1Zn8-LGjxvn8qq9ruH9nrQTOZPanymZltfPg6au_89_l-wgTyy
Screenshots

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in Path of Building with any Vaal skill and the custom 100% increased cost efficiency modifier in the config tab. Trace the calculation that reduces the displayed soul cost and compare it with the documented in-game behavior. Done means generic cost efficiency no longer changes Vaal skill soul costs, with the reproduction remaining correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
64/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.