PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Incorrect EHP / max hit calculation with Dissolution of the Flesh

Open
#10,193 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

How is Path of Building expected to behave?

When you have Dissolution of the Flesh equipped and reserve some % of your hp, your EHP and max hit values should decrease.

How does Path of Building behave?

Life reservation does not affect EHP / max hit values.

How to reproduce the issue
  1. Add Dissolution of the Flesh
  2. Add Wrath linked to Arrogance (so you reserve 100% of your hp)
  3. Observe how your EHP / max hit values do not change (they should be ~0, as any hit would instantly reserve >=100% of your life and thus kill you)
PoB for PoE1 build code

Screenshots
Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in Path of Building with Dissolution of the Flesh and Wrath linked to Arrogance, reserving 100% of life. Trace the EHP and max-hit calculation from the relevant entry point, then verify that life reservation is reflected in both values and that the reproduction case approaches zero.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.