PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Weird buy similar trade filters for all ele res
Open
Nobody has claimed this yet.
bug
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?
Windows
How is Path of Building expected to behave?
When you open a trade url from the buy similar dialog, the filters should map to the selected modifiers.
How does Path of Building behave?
Some mods (like all elemental res on rings) have some weird trade filters associated with them.
How to reproduce the issue
- Add a ring with
+#% to all Elemental Resistances - Click
Buy Similar, select the resistance mod, then clickOpen URL
PoB for PoE1 build code
Screenshots
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the Buy Similar dialog flow with a ring's all-elemental-resistance modifier, then trace how the Open URL action builds trade filters. Done means the generated trade URL filters correspond to the selected modifier instead of the reported mismatched filters.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100