PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding-PoE2
Small issue with AffectedByHerald---
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 1.9k
- Forks
- 451
- Avg merge
- 21h 16m
- Merged PRs (30d)
- 68
Description
Was looking at someone's build for an issue, and I noticed the very small issue regarding AffectedByHeraldof----.
if gemData.tags.aura or gemData.tags.herald then
skillNameList["while affected by "..skillName:lower()] = { tag = { type = "Condition", var = "AffectedBy"..skillName:gsub(" ","") } }
skillNameList["while using "..skillName:lower()] = { tag = { type = "Condition", var = "AffectedBy"..skillName:gsub(" ","") } }
end
This is in Modparser. The issue is, it takes the name of the heralds, which is something like "Herald of Thunder". The 'of' has a leading lowercase, so when it's printed in the breakdown, it shows "Condition: Affected By Heraldof Thunder". As you see because it has a lowercase, it latches onto the end of Herald instead of having a space between.
Again, very minor. Probably a lot more work than it's worth to fix it. But I'll post this anyway.
https://maxroll.gg/poe2/pob/5seqe00h
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the Modparser code containing the reported AffectedBy construction and inspect how herald names such as "Herald of Thunder" are normalized for the breakdown. Reproduce the displayed condition text, then verify that the corrected output preserves the space in "Herald of Thunder".
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100