PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding-PoE2

Bow Attacks not calculating "Bow Attacks fire an Additional Arrow" or "Bow Attacks fire 2 Additional Arrows"

Open
#783 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lua
Stars
1.9k
Forks
451
Avg merge
21h 16m
Merged PRs (30d)
68

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

The calculation is also missing in game from my research. For example, I have a Dual-string bow with suffix to fire another arrow for a total of 4 arrows. The Lightning Arrow skill information shows that it's only firing 2. I believe this issue is both game client side and in PoB.

What is the value from the calculation in Path of Building?

The damage per second value is not modified by adjusting a bow from only firing one additional arrow to two. In my test case I fire 4 arrows and an upgrade would see me firing 5 arrows for an increase of 20% DPS (or 25%, I suck at math). But in testing and manually modifying an imported Bow from PoE2 I've found no change to the damage profile.

How to reproduce the issue
  1. Ranger with Deadeye Ascendency and "Endless Munitions"
  2. Dual-string Bow with Suffix "Bow Attacks Fire an Additional Arrow"
  3. Copy bow to PoB2
  4. Edit bow to have Suffix "Bow Attacks Fire 2 Additional Arrows" and remove "Bow Attacks Fire an Additional Arrow"
PoB for PoE2 build code
eNrtPWtz2ziSn0e_guWqvbqtUWy-HzlntiTLjp2xY8ey42S_uGgRsphQpMKHbc3W_PfrBkgRlAiKku9utXvZrcrIQHcD6G50NxoPHv7tZRpITyRO_Ch8t6fsy3sSCUeR54eP7_Zub07e2Ht_-61zeOWmk8txP_MDrFF_6_xySP-QAvJEgnd7jr4njQI3ST66U_Ju79oNH0m8J7nJiITeUVkxIK5H5mRPSt34kaSfi4blewUITNzYHaUkPkeivSyNLiIPkNI4A4yp64fDaPSdpO_jKJtBZ_ekJ588M5izi6vL65s96Ngvh1eBOyfxMHVTKYF_3u31YIDuIxm4U_gXsNwgAxTFtE1l33QcxXFMRds7aETuZ3GSbkdhOCPEWyBp-7qs6SLYq5gcj8dklPpP5Cj206OJG47KFs191RChbgF-kQWpPwt8lFWOoorgT1eoK7IsAr6JUjcYXA0XsIal2da-IluyYTim3owXpQs8YQt3fjrpB8DYLVo5ewz9lPCI-r6qqbpsWrppmJbZ1OgqMrTqKPua5uimailKE_JV5CdR-ArGbNHpoywIYNLymEKuXpOExE9u6lc7KYQ_iqYPfrgihDbs6MXEvRwzZb92PT9LLkgak6TUxH0hNy7c0D2KklJNdLsJ9IrEYIfSCoa8BmFIRhGYLh5FMbV9zdTUFk3VExC2ee6PSXvIjYaTI2zam-3GcTxsC7cx4e06dA3muh3kMMqClpBpaS0tEdCAvJSK7Oji-fajAqkIlessLLumymYDwSqkIe7hU4TzfP2Aqe05Pr0qR20Yxr5tmJqhOzDHhb5sMk_8kRtcuC_-NJuCA7lxv5OyQdXWFLEOPk7SEMyWCNmxdKHDPfFjsg3eURR4W-FN3CgRIdqq3WDH_PDUDb3eaJRB6DMvWaPqQk0YuPH3kCRJW2sO1rk1Bk790t7pit4Q04zeIvRZOCqH2kT2Nozz7rRqAFGuYaZj9PUQkNY4ZTO5xWgTrrDGHkmYtzhvx6lzQkaT9yDDazcl7TwLp09GI28RmOdtI9Ua3jbQr2JswCZErGeTru83euANOTWc-RCdll0SBzcMsmb8aluMlfHvK-DkF_8XeqSQxI_z4cQnAafQmlg5eYSCf0furBUu1QieAK8ZltquyY3Um0fdUHjoczdt7clNeFekmobczAuGwLNB1YSO6ILAQgFQPLK0gtEV8Tos-oarsGBDvF48jbK4jYbDKBhwq1le-FK2Ar0mXjZq57wXq8l-AIvnpXGsx4J-BsFGqL00dUffB5H3SNqi0EY2wqj2b5jNZjCdUSPaEsAQAdyjzwV8YoNZAl-CPvOT1rCaYonWDZTAyw2o5toIqXUrSxjtm6LxTfvBlNDLTShr5XkBFmMK5pjmTC4izrTuwypXKCBY4rZar1LA6ipaPOWiZ-j9BBNVyWbQEAqW6R5hV2IS_jFvTb8C3qqB49CDoBJmQ-s2ljHqmuln43EijWDd76bnIOJ3e3vSA5Sx36cQrQWeFI2lsxHpSuWfN5Ms9EjcxXKp76dQeRaGNNcAPxeaKfXiOHruSnd-6EkD7ArYUoiNE8Lof46C1PVH0gVEtHmHbvwpmPckGbipK3n5ouazG_tumKo0S5gQNx5NkMCJGwQPYJ2w02Up_YtmFk_8ICXxAMqwaeTUMkWlUOLDA5oAxV9n01kUpxJ5wf9cuXE6f7c3doOEMEBaAnSS1A9pZgVsZBDsScNJ9NzznrClmygKkgJJcmczEnoVGjcxIZJbWLwRdoIOHv-Qpm4CvZ6zOZTgaLi865lHeRBG0AGwV4ZqGV3D1hyrq-uGaXZVw1a7muHISldVLNvu6rJs2l3NtFStq8mObHR1TdGgUlEAUNdtKFYV-NewFatrOKYC6KqmdzXHhr8VUzYBDGKorgoFSle3LQspQZtdWNXAv6as23LXVHRAhTWg6nQVVTWAoGLJFsBYtgklmmZ1FSCEMLKuw7-OowKWZmCtosrQDcuEjmkaVtqa0TVV3YR-yKYBqKZuytC4ophd3bRxkKZl2YBqOzJ020IChumYXUN1jK4GQ4WeKY6qIAEsUWUo0A1dw27D0ICKgS3Jhky5AUODUUGXYJw6dNVCzhgmDFkDjgGSbGEHgB3AZ0PpGppjAu9l3QBGOLoF_yo6NKSbDvQIuAdtKiYQgU470FEFQLuKpYGQNEuHJjRLBrbJFo4ReAcjUhRLBbogI9Wy4F8QIHRRt20dcFSkBQPVZaClKQBjyAZ0wLR1CwamQDn0EQTuqMALxcExA-dQejJAm5ptox6wjmogT121HOyFg9QtDXqnOhqKX1dBeyB81aDvjgMs1RUDJWzIjoIdBtHoqg6CUBRbhV46NjSrQNegTzqWaCq0BFKhzWjQe61rIct0xQYYkDVQVlQduIIAMADgumU7XUNH1tsKyFuTQVegMRgjzm1MEbnxvFedCKEP8y6FubS08VDUy3RW_XJ4e31Of_wySdNZ8vbg4Pn5eX_mppNoTF4gJtwH-3cwAySYj2-S734QvEGqBz34X_-x1x-n49joq9nJY3T3baB8Pv0wP_6mfdSz68Hfb0P_faKp2kn8_cvw69QfGFcfgujzV-_3N28mXybalx_3yaer3ueHH9-ftFFoff149nxxc_3t4evLy6fLN8m5Mrl_8_ydjH6_knun4_6n47nlnI_8b2Y0v8uCM1_r3cb6yblNTjTjef7hvu8QzRq9f_j7h6FnTn53Hh8VRU-_DO480p-cv9dun4Z_fLkIb-9HV9-_PA2ejr8m9vHV3ffp86V3qYwmf1wbL_2h8TAITp5i63JsPs2-HD3_8dW7J4P7HxdHd996173x-bfs6Fi7n376Fjo3d7-PfgSDH9fZ6e8vk78H5nz08SKa_vHm0xv5fvbQyy5ulcerqff45tPJWa9vnfkfvt6fkstv3-d2_-LjWf-2_8N8H325m_fvPS_6ktx96vWoYA4KyRyyraCEiSn_i1o5lCO1DHsSuJkptX953LEKSC0DB2iIAOk84gA1ESBVdw5QFwFSU8oBqkJANAocYB6mATN4HhxirBX7YOVzKhCHx_5DlpKiAlzQy0fmBoBamOa_mX2mboBNRjaF2SxkjoGZAmY5mXVllpP5ATrncgPEDD8zCNS4MNOZmztqOplJzi0BtfvMVLO5nFt_avepHYLJnMZFt4uBV8YKfAAvSF0yukn88TFKWR0WFn8cDnGiJuDq4_Q9mSb9OYSBJ7jAXdrHyP0sQg9JykIIHqfYkfTI2M0CLP-UuYGPbl_mS8_Z3mgYxdNFEhRIgdvHBQujeDOf4ch65-e5Q89blXyvcPJ5Id0A7ZVdO3KDUUI754ejIANdCfMweBFIBO4DdgC3dDGH5vFbqRylRUO_HEKPaCwIPTiDeO0lN5kM_30QPbiBWlDJt35VuVqvFPVPLGJCnV3EdzS8Ax5gs6sVLCDdk34U7ETaj0ztL0jqehDiHZzBPEgOUBgHtPfI6CXyoTvNw6SlwHKFE6MoC3MJc6POWYtDP9ieMcp6vkAwjLFwrg4cX_KSvH6FL2vYstCuHJ_nSBF_7xorTmgQy5IHQn7wQFszBdYOqe8GNwTCdp4zebmUV-yYpoTJzI_p8kGsLSXM9hpT0qhoDV-8a5zJl5ENfMkhNuJKhSk5gSpLFoW7xZA74s6i8DigeZQiYyhkTi301upzFfvg63rg8KY0p16yi9VIZdV2TDtkRv9fwC8qzgZ-8RozXateEYo384mrLpFSrnOItGK3NDc_jkTK5Hsi1Nsa2K21djhyU_ArEJlVVLZSvFucOopC3LQCi0w8lvcRMmoVdGs-rZLi2cXXSkX1brHtlIzFjMLKbT0E4vK8YH_v1uBx0TSiiV0hC0qQrXWkJMHzgy_9dzf8bRZEl_HD5XiYwsow4aTAlW67FKoQ5vgfP2AWvqjYtQhuFBMXU_xTP22I4jioV6mn-5CFHtsmrGooV7FbHLoNAxj6RMibvH5rruT4PD8WRTvm-CZ4DFzo67B2e_eG2BWPxgp-GqzFxhvddyvZzpVuGadW6Jacr-zz7VqUGsVkkInW4jW126-mcJciScmSqaoU_1TOYtf5cpxvMnPSWKrZ1quuNMBHektb3Lumru8Dd-Q3J45KkK1VtSTBM4cv3bV0Y3xEzzA05BpziK15ch6Fj8tryrJst_jR8zzi4TGkNemiJbhXLCXxEOM4S5Y0BsulsmK3mMQdSqcnLoRcWgbcXoWWCNWnchaVP51BafLP0DuuOAIofa0TOKt648qRp11dWnn8bau1S6wK9Cv2WR5Df-zXpYoWVTuaJ2KnSG-i4SRq2I2qQL0mqbY4zFtJpi1Kd9BTLGxPG3exBPx6Y1jnOEpruKveg90uanYcHMyrXGuNu6Ce9V_KU6j_y57iCJhxGdLZyy_ggLlczbbeokKckwIUS1Eo5RX_hxrahiN9NwgWE4njSaV8U8XMGbJEu2QJVkhczW7N2mGAB7vb7EitQG49gwdkRAKyugtfLd-xSGM6I2km5k5ev_UWPEOvbMAXRT-jXlhpx_70BGI3nvOLsi1zcxxNbkkPhVJe-pPx-KpD6BUXFRacLwu3ZD1PteR95VbEbk3_fgB9E05-Wru1OaTYFY_BCl6tfvlPAKWnR9n5UPxJkSjEWTjLUtr0u72pn4zu8a4LPjlDz6XSV3KOT06Oj27OPh_nF1J4FMqI-zCbPlBJ0v-W16CGhEb4UpI9JOznu73PPnmmHRkAT_wgwXEFgTtLyOJGCD0bmvc8wNWTmBqFOvUXD9fU0yoBxJSOX0icwnjv3HgU-0TYr0X9mk6xBvF-KF7gEVHDp2DEhNhBQAyp2M1UAafo8ztiKvgQjnA4WNmACz7IDYQt57VrOJHiEWDQa1gQj_AyVrPI8cAwg2rgy-I5AaG883uSYhr0bR0RAVYpRmbP3Iiw89oGrtIndoRcZbVidAiTXOHYWaUYeXHZOQpP8Qp6PZUFVAOlj1FIlRzPJfsBHnoTSvY4IAsQMcHLdELi_JaXiNIF2KgCpHHisLsBQjocRAOv6GsRAg5hnRiVvYUgGAPWNUya_HEA0Wz3m6ds9eK-QB48jJgUu-Qq5GF-Y7ZBDPllcYEIWG3DSIpb84JB5NUNE4Xa4N5T5OenHgRTZgmsyWjQVe1rydCr4K8ns3w3_PUUTwI3-S6Ud14rRr-FZSFEPjVUWATTighOrNdRwPn1Ogp4P3i6Nfb1cihS4l43ByGLm8y1yEVt09zPLzhvTYFdw94and4S3xqbOoABGePOf6MHWMA0TI40C4tzCq8kRbtVb0XK0W1Ei_nC2pFuTJHN7vxNpiYDwEDWEAJnftoQLrajtHjt4JS4AT4KGAWvI7jy9tRriOGzLdnMDb2C3GVdkF7KoSX3ojQBmvTS_ABfh3ktD0MyndcQEvfr8KBY1tHr9LjQyh8BGKYxphL-iKLp13d7byxnXzVNWzYMW5U1m1Xkl_ns_AIfROADH8QYU_UrmkXAL0DBNs19Tbc1W7Yd22ZvhBzStW1-uRB_L-4WiullCWGv3bFbGhSDcYqtNIEKf1HwGtbj6fytdN27Pu68jwKovZn4cZJ2jl9msHyTBrD0ZstWqR89dyg-HdhbyVY7-S3Gt5Iqd_KrpW-lIf6_c52FBH5HWSAdRTHB3c4jP3VxKR-lwSuraQ-uyY-3kmV3YM0U-CMfm1Y7_wBuwEIl_fMfMZD405H_ghkhtkcpLe6sSEzS0rOfTiS2Jkw6ML7itzT2oVE3lFzP81F76D2UGBhg6DzB4o2dnF6n53mJpDhSGkmqLuEjMJUaEysUw-Rer8irFYcny3oh0WVou27hwkLSVAldvQSCk6iyS7_D8g9IAAvjbJbCL8xmXEQefW1XivHfd3vyvrGX60Se7xBCqGshtLUQ-loIYy2EuRbCWgtRvD5GM0jVyaHWTI4TNyVSH3mdz4wbWO0A_y8gdOnkgfNbyVCtDlsKSGwtgFPDqk4bXTBtcqU_i8Fu4U9eyw1ey5VlLVcrWs5WAV0p7xToiydV-tT51TRQEwuAaxfTNJ1fVRtLp8wzLKHYdmUiiUk7Ck8E9bGjVbrHuEpPP1DzNo6yEPA0ijcgLynB-qI3Z2EKIbn_iEbup_a20l6tRnuPXDAgwTyZSh_AkBQqfOfOx24M1gILSVqqsWmYK2qsV9UYDK_I-q8ocoNiy43mW99UsRVAAK2hD0pJbDWNEWZHkY2W-qvLK_r7q0l1k-UJOgpQivE1NWaoWc4D2vqRgXGmCRnQXY12gzoArhe_qgbrHm6sc-U_9bqNXutVvb79ePbp9riDj6GiMbnzEy-aUon2aMDXOcliDJykuxgCPc5Ey8uqrThCAy1zumqoAiOcBxNXJCT0LhuEACD_ZSGD8JctnLJi4TRRGECdOlAo0VmsQSMKeSWgwOIiaEBMAKm0868ZEdRphVGrFWeAH2bIpjyDIvVJkHZoFkIaQgxJJViRusaL2lgyS6n7mLwlVG3uE6o2XS9fSP7J2Szs9lvo9Z__qRhvVOOvvDTr_Sq6btBemgGRiucv8T2vAM-6nYWoPGkw71gV__sQhRDoJ9Kji0-QSOMYNP8YDNBshg4W1CD5J0i4TjpWjS_qPUbhHKaHH3T6MJ7RhPZ42blwwtCr8y5fukr5JJX8BOb0X4o5K_0nd8o18vDMYJz89a30K8LQOaPh5ACTXsJ5y3MGHIlh14RIqtoiklF1auTxjEq54CgNARDXZIF70Oq910__0MY_2DW6djydzUFaoXRBPBAIuoVhFLix1JtmAUQ8FaVzmixAMcl7QRCNqJE_Bf2RegEEUqguXISw0EQmyIoWwnzvaEpdLJKrmKatNxrQnMVHKZieBe3BIjoCVElUv_JkkcR2qkH1VKpi3KV-Xv_Mf5L-7Zh2NUA4Yv1zhLZuOHPjRdB9moUoaDzPR7iwRLVX45LllaPavHIc4PvU6YZrx18VtdYYaZWAuXhkNc9JKIraMpzW5KWgJ1fAmuioQTEVarMxAS3dTGKSTAD7_51VrNM5Ra5Run7sT5M0CjH5BMbpMxg8kNynDILhuKpQfHhrylU9Ua3q2iuOnnPpl14UzFCTF9UqJPicGya1cpOkV6whb7KYqlUSbni4gibcTv1UYicSwO3Gpd9mWYNS32hiTFGpiVxNjP1UIfrUYY3dilFWngeT-iiL_QgcKb20sqw-nMbIHV24eClknnSqhoOTdpEIrWgDTWcuomIa5rK9wk4lHKaXQ9LMo3ni4liENI8ygBlD_9IdEnStCOoSjqdRGGXxIh1fw38IWCr819rwX2nmv9mO_dVsCt2cQt7Pscd4A7uY3DvOd03Md3Cm4BHr9V6t8l0xG8xc0qmk9t0pnjlEXlGLRE8FEbYMFOgzPfdfUWa1wv2qV5R8KgVp4j6R8D_cWZT8Vyo9EBJSOFwsgjwJXVLuuGz0OtnMZ2EEDgCkE0ConU3r5aNU5aM2RTJGVeEb92WWQvUqLpVn7WTZcUYbNYy-fAj8JxzqMHXjFkzmwspfrZWsVtXorEyQVnarJa_zu5X5w60egVChKsNcsP8-CTDFrFv3hmkczXDlEfggiXoRVvdOm-dJGxnV5EHBrNVG9GKNwLMSkouJrSTFDAuhq4rb0P-RERq8-WTnZ5TTGJSfR9FMmPmCabV95otd2KtPetF1mGaxhVddwsukEX1xELiwcbrTJuNlLme216XAfgbeiPw_sp9hruQNVG2jDeePUSVfsMk2h_oXUSZJX9IIdiji517HtqYeH_gWn-2pvv0dRCl9-_3q4fb6HI8psZsl7wMw6Un5LPxCeUUIrBlJ4V6SX4fC9jE4DHkdBkvElgj2OgS2h6Nt0ATD2KRTbBjqBhg5r_gvA6zFwS2pEn5hbdgEPfMAdvmrAwzvA3kmgcR9iKCg20Ag_8gAT4D77sAygTUKIQ2f8RNNrZmDXo5njdXU0_zjBXxPue8ZtOxpP_LmUnFYvmhWa2o2_1wD3yz3BYfNGKQKGVQ3XvZVh8p4yw89tGyYcpifqE67SbGJip-SYMrPVLVxVOx7GpVRlZ_YaC3FKOUMViX3zq7g4cFM1wOziIcy7wh6hoSd3KQBCr2ZF4Vj_zE_Rcn-yM9RUvxFiZT6aUA_OE-_xlC1qVeBOyK4vgb_wvpGMI-Yf6e9uKVnyQsmChAq30Ur0NYhLb2GUSI6prGuPe4L7wVWAw57vYS60pW7h-I2Fm87bdIz3G_YHIuGKSWCrYrhp4sv1eNn1ElMPDqwI8y_DEkw5gZotBjhstCM1lK7wuPVBZrWFmvj9hZ3exbM0dc1Vv1E5EZ6hXq8jKbZZgtGbsSO4sNqJYba0LXEf_SDyzG9MgHCpvc-WmtxvrMAJpx--Xh5FqhyK1XDu6zzW4hoizRb-x7wH5hsI_XhKKIn0TecrXF5t3chhXW6VXjSRSOKoZpt-JEnHTdnRv7V0igIaJTM29gWbGyrY0cTvBJdz8HDg4VrYFcB6F-_dQ4Prtx0cjmm9xJgoqq_df4bER19oA==
Screenshots

Base

Image

Modified

Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named in the issue. Reproduce the Ranger and Dual-string Bow setup, then trace the Bow Attacks calculation path and compare the one- versus two-additional-arrow cases; done means the calculated damage reflects the changed arrow count and DPS.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.