PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding-PoE2

Support for Thorns Damage

Open
#760 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
1.9k
Forks
451
Avg merge
21h 16m
Merged PRs (30d)
68

Description

Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

POE 2 introduces thorns as a mechanic for players to build into. This seems to be different to reflected damage found in poe 1 (such as on Bramblejack) or on mob affixes as it appears to not scale with the damage taken on hit. My testing in game seems to align with this, but I haven't been able to get high enough on a thorns build to really tell, so I may be wrong here.

Thorns seems to act mostly as a triggered attack seperate from weapons or spells with its own set of phys/ele damage, crit chance, crit damage bonus etc.

https://poe2db.tw/us/Thorns#Acronym

By default thorns damage only triggers on enemy melee hits, but has the ability to be all hits from Thorns damage is triggered by all Hits mod on https://poe2db.tw/us/Crown_of_the_Pale_King

Thorns build: https://mobalytics.gg/poe-2/profile/6f6fba9f-ff73-4a9b-9c8b-e51b091c06a1/builds/a41cf294-c954-40b2-aed4-307e9168fff9

Describe the solution you'd like

My mental model for thorns is that it is a separate skill that the user can select on the skill calc dropdowns. If the player has any thorns damage on their build the dropdown will include a thorns "skill" to select. This would be subject to the normal damage calcs.

Describe alternatives you've considered

No response

Additional context

Items to test in game:

Do sources to + damage (such as +# to +# physical damage added) effect thorns damage?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the skill calc dropdowns described in the request and compare the linked Thorns mechanic with the game behavior and open questions about added damage. Done means builds with Thorns damage expose a selectable Thorns entry and the requested normal damage calculations represent the mechanic.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.