PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding-PoE2

Infernal Cry Empowered Attack Support

Open
#714 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lua
Stars
1.9k
Forks
451
Avg merge
21h 16m
Merged PRs (30d)
68

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the behaviour in-game?

In-game, Infernal Cry empowers my next attack based off of the power of enemies.

What is the behaviour in Path of Building?

In PoB2, under "Configuration", there is a checkbox for "Is the skill Empowered?" which doesn't show up even if I have Infernal Cry enabled and checked for "Full DPS". Even if I show "Ineligible Configurations" and check the empowered box, nothing happens to my DPS. Furthermore, even if I adjust the "# of Warcries Used Recently" specification and the "Warcry Power" specification, nothing happens to my DPS either.

How to reproduce the issue
  1. Add skill Infernal Cry.
  2. Add skill "Perfect Strike"
  3. Have both "Included in Full DPS"
  4. Check to see if the DPS is affected with infernal cry enabled or disabled.
PoB for PoE2 build code
I'm not a coder I have no idea what code to produce here.
Screenshots

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with Infernal Cry and Perfect Strike enabled and included in Full DPS. Start by tracing how these skills expose configuration options and how warcry power and recent warcry counts affect damage calculations. Done means the empowered attack configuration appears when applicable and changing the relevant values changes DPS.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.