PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding-PoE2

Remember query options in Trader

Open
#615 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
1.9k
Forks
451
Avg merge
21h 16m
Merged PRs (30d)
68

Description

Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

Currently when clicking the "find best" button for a slot, the query options have to be set for each search again and again.

Describe the solution you'd like

I would like to be able to set a default search query for each slot individually.

So for instance query options for Weapon 1:

Image

Default query options for Amulet:

Image

These default values should be also applied when clicking the << Search button and beginning a new search for a slot.

Describe alternatives you've considered

No response

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Trader implementation and the handlers for “find best” and “<< Search”; trace where each slot’s query options are initialized. Done means each slot can retain its own default options and those values are applied both to new searches and to the “<< Search” action.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
desktop
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.