PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding-PoE2

Factor in curses (and possibly other effects) from secondary weapon sets (2nd item + 2nd tree)

Open
#510 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
1.9k
Forks
451
Avg merge
21h 16m
Merged PRs (30d)
68

Description

Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Linux - Wine

Is your feature request related to a problem?

While manually porting my stormweaver to PoB2, I realized the damage calculation does not support computing the effect of curses from a different weapon set from the one used by the main damaging skill.

The curse gets disabled once I select "socketed in: Weapon 1 (Swap)", even with the checkbox "enabled" set.

Image

Note that I have conductivity enabled, and just in case I also checked "Include in Full DPS", even though it shouldn't typically be needed. The picture doesn't show, but spark is "socketed in: Weapon 1" (i.e., not swap)

Disclosure: I'm still updating the tree, didn't allocate yet the curse effect nodes for weapon set 2, but my current second weapon (staff) has +level of skills, which should be enough to see a difference. The issue isn't even the value itself, but it seems to be the fact that the skill gets automatically disabled for being "socketed in" a different set.

I cast the curse exclusively with the staff, and spark exclusively with the wand+focus.

Describe the solution you'd like

My expected behavior (based on intuition and how I play) is to have the "final" effect of the curse computed on the secondary weapon set + secondary tree, then factored together with the damage of the enabled gems/tree associated with skills that has "Include in Full DPS" marked.

With no intention to sound arrogant at all - one important detail when implementing this is that nodes from the secondary tree must not apply to the enabled skill from the first weapon set. In my example, I used spare cast speed and skill speed nodes (from weapon set 2 only) to cast the curse faster - but that resulting cast speed boost isn't applied to spark itself.

Describe alternatives you've considered

No response

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source files or tests are named in the report. Start by tracing how socketed weapon sets disable curses and how Full DPS combines skills; done means secondary-set curse effects and tree modifiers affect the primary damage calculation without applying secondary cast-speed or skill effects to the primary-set skill.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.