PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding-PoE2

Cast on Spells Enhancement / Feature

Open
#505 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
1.9k
Forks
451
Avg merge
21h 16m
Merged PRs (30d)
68

Description

Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

Currently the Cast on Critical and other "Cast on" Spells have their text highlighted in red, as far as I understand those spells are currently not being calculated and are not supported in PoB 2. There are so many builds that can be created surrounded the mechanics of these spirit gems, that it would be a nice to have feature in the tool.

Describe the solution you'd like

When I am adding Cast on Critical and Cast on Shock for example, it should be able to calculate the energy gain based on a primary spell along with a chain if any that can be created due to such spells to create high efficiency builds.

For example if I have 100% Crit Chance & 600 Crit Damage and I cast a Level 10 Spark Spell how fast the energy builds up would be nice to know depending on the enemy level and the damage done I assume? And then if such mechanics can chain, for example if I use the "Choir of the Storm" unique, it has a spell which is cast on critical, that spell can then further build up the Cast on Crit energy and cast the spells socketed within the Cast on Critical spell to possible create a chaining effect.

Spark -> Choir -> CoC -> Choir -> CoC etc...

This build of course could possibly require temporalis for cooldown reductions etc but I hope I am able to communicate the kind of calculations that could be required, and in the case of infinite loops perhaps there should be a limit to not crash the App and also a warning that the damage calculation can only be calculated upto X loops.

Describe alternatives you've considered

There is no other way I can think of to achieve the same functionality.

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source files, tests, or entry points are named. Start by locating the existing Cast on spell handling and damage calculation, then define how energy gain, chained casts, cooldowns, and loop limits should be represented; done would mean supported Cast on mechanics produce reliable calculations without unbounded loops.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.