PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding-PoE2
Secondary gem effect added into FullDPS
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Lua
- Stars
- 1.9k
- Forks
- 451
- Avg merge
- 21h 16m
- Merged PRs (30d)
- 68
Description
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?
Windows
Is your feature request related to a problem?
Kinda related to #412
Describe the solution you'd like
Would be great to have a second Include in Full DPS checkbox or to have secondary effect also impact the full DPS when checked, instead of switching between two effects in the left menu
Describe alternatives you've considered
No response
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing issue #412 and the existing Full DPS and secondary-effect controls in the left menu. Trace how the Include in Full DPS choice is represented and calculated; done means the UI supports the requested secondary-effect behavior without requiring users to switch between effects.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100