PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding-PoE2

Update leech to PoE2 values

Open
#328 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
1.9k
Forks
451
Avg merge
21h 16m
Merged PRs (30d)
68

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the behaviour in-game?

DamageDealt * leech% * incLeechAmount * leechResistance (I suppose?).

What is the behaviour in Path of Building?

Uses PoE1 calculations (cap from life pool, stack cap, etc).

How to reproduce the issue

No response

Character build code
eNq9W91T27oSf27-Ck1m-taS7w-Y0DMhQGEOKbkJ9Nz71BG2kugiWzm2DOR0-r_fXcl2nDRy7DBzeQDb2t9qtatd7a7N4I83T5AXFoRc-ufVxkm9SpjvSJf7i_Pq48P15371jy-VwYSq5f38IuICR5pfKh8G-oYI9sIEAKvEETQMv1GPnVfH0n-uEho6zHdHm8dDR4q1YkTOyWhJ15GgVaJosGDqeyJA_QdyWtKAOooFd8h8GCk5li7gVRCxKvEo92fSeWbqayCjlZ77hbNXQ3M7ntxPH6og4IfBRNA1C2aKKhLCLxAAFkoX7JJ68BtQVEQAadTx56TTb7VanUanWssFX0RBqI7jMFsx5m5AJ20b4SRgV_M5cxR_YaOAK9CW72SnswFLE48jofhKcBakgKaN_mYPbyvzB6mouJzMNrRtraN-o9vtnjYb-TipUpx1hr-4Wl4I0OgRsyD2duFzxY4ETyQPpf-O9WWhdgtFQoC7FaKdspAFL1TxbbHsvKX3xP2jtDemPh3JsICNkHLCAogDqhRgxhwJoaPsHCWRd3zOilOWWkcMKCvNceu4mhWlK834OIGmEByLUc5kJApSqk2I6tmILtnbZjM37K7y9xZh1xqxb31VjF-WsNu2i_ci0UEPr1aHiaubyYZp_6Teb3R6vdN-v9foW0-O5TrkDhVj-sa9yIOQ_UCf2WbCbs--_RZL5UO0sUHb1kmvecDKo0ZSuEegllSG5Vc3hqThhvru0HEiyC3WKaTTyfPHApzhUHfOkPbWd1Lyfh7TRz_QsTqTC-SZZc6m4HqYfDwJVhCxmSJ24CJHtplqwfx4vnWxmHXHmLP8CvqdUrWR7_Sk1c-L2BsDdHM1i7RZzeYeA3s0a2e_DSihJwTu11PzpJkH2q-p3km_bVcBhyStiFCGco8CSmBK6ODKZ8FiPVtyJtwC50iGOlHaiK4KBH3cAll0oa2wPV2pDZ2F7jeXPR-lgVvsaCwr0wsNs4dG64C6DHkxp2GQQAPAZTuZfddemsj_YmEiysGGgSejoKDBDXGhBSTnnSnIpsyNnGIHbFpfXQioJXeWcRgFcgpRCjpUijrPl9JdsKIQPUkpxLZ8s2i1At_G3VCUAR7lUEnwTEb2uV2A-h62ciGPxlO_-AQb6sITpHlM8Vl2IMXXgrnIzjRFiAtPkJpzDKHCg9CsOwhjmYnuVtNA6VioDtSEBevRiXwFyZfYsgnLUUPGtolfVlEC5v-zLsx_i7zQBFe-C9kfOELhOXYR-6a5iObzkDhQT1N1B-Y9r1bJEzxLriHjDFl8YxAP3IPAG4aXVFHixkXBdxpw6qumbmiFjAbOEkHXVIgniBzIafMU73aAjWQ3DGq6NYdXt95KBoqwN_wzoYFan1fnVITMEOonwCdU3NedAwhTQlTJbClfh-4LrvtBShEmIEJXK-a7WzweAsYITYKOg0LoNeIN8Wio4Iwz-zhEoTNNwVsXm03ElyAApPztbr_1qdHvN7ufGr3TZutTr40rxqqTBuvhNs7nIKaCqXc6h8l4RwvxYfA4vdMXH5ZKrcKzWu319fVkRdVSztkbHGInYLbaCkAg_ufwmQvxGbnWhvBzsXgcDZ-9P6eLMdydn2uGtYTjwPQgw5q5Q58OOKzETDeAcB_wp0ixZADU_PbNLLVKuK_S61AFyXXMq7bFbFBDVWq7oq7x4ptUZgwfJjeDGYofkhBM_ZV54cUafPoaE5mdZk9sLKSeMWW2WxaTNFpdNqeRwOf_iqjguHfq2ad3pvXry8BLC05gBXsHDx7D8WG9wpUN7-7iXRHPSrib7JT4oe7rDjeijahwwtjQ3HdE5EKFFUe1-LGgTygAdqyxNnKzHeIMJ0Ndi3UZC6D1aTSGl3o2TXHrryJFfN2w9njo_EBXxt6ytpRui19dX1-NHm6_X8VMsxC9h374kfeELVXzdxOmZ0ynJySMnkJzeV79ztmrFuSSKcoFBCVHCkFXIUsdTWsrllwALoebpoLCOOlQ7-e1IbBzunpjAcSFBeS1TsCZVa50_IBQZkLMeTH82bhh69fOyCRRI4gqJie3aEr32e1csPFtXQ4O5mAholJhnTkePaAJhU4BPs3n3MGzJt_k6EKGKkcvaVvDau84A7Tz0L10GwMzaAebfrgNHY_maFX34q1aNaN2-CVzqHXtZtAOTss86d9grb2fS0qVw-mb9PUmB6cZcoH5mtWyV4KlJHaG92rJgvjwtHEaQ4xKSHIdxxxHVj4Zihxd6Z6YRUM4Zoeapo9lDTiW4zRxF8Tm7TzfZbd7FRZ7ZGnsrEyNb42DeVCT-lvVH5cRORaMK2iL9cxojhKSJoJl_fFwjo_p8D18kdw1paTF23bI8uINJFDvZ6Pr4_ez2S2Y38_xGnLRZ6u941E7_FFxzLn2cDFJTiEm6JPv44Cu-T4OWDl5R6Onu1nMBjvNz1_SGm8vOBnNCxtx6Xc0B1OgHg3X9fPRaH12XLI5gxXkHh4pTY5zqMi_BGWoHMcoyEqLtT-KbFZXipc5RveutDRH493xS6W8AGBIDjCCPOAmJ9MsxintAd0wKvDDAynex_C3l2fvYYZd7GhFfTdhd78vv9_YoaD2pAqBp25jXGKz_L069Jm33sPILtegllSEusGBNVrcfZmpAEvOf6T0_nNe7bS6J_1m7_T0tF1vdnvmeVwYN5pxNQzJ-yUHMwZ6-yXTIuW_z6ufG51m66TTbzQ7rX7fvDMb3CooxuNCHa_TOt3OLgqZeUX_F6Mr6WsE1r2mQgUe2ZJ7SiFlWp-R6XB6VfkGa0OCytXbCko-cif9BYGSP1AsCBWdzyujgM4Vc88ITlWZBGzO387IT4iOC3bW-HUnHSpufSdgFNS63ZKP3yn1Laih6-4iHl4lvqk9TRGQVrPKDKrwAjdxp-KMNOuVuEFzRmZkVplGPjsjtwHsDLz87V7bbMr-PiO9XgXKOMEdjthm5SeoGWon9etnAIS_2vWP2I8wayWJ6MTIXvmp6CI8o7pM_dXoZkmnuO5Ko3eahwd9hKTTIUqS0_Zvo9gsGUtXcyJaj-fV-kmnGps2bh9ZKZoHKVoHKZJXlTXcMdt7q5m3ty5gwc6STCEmWraTtp_9JjFzvH9AoF_p2-dmzo7YGLZdzxq2UYkDIYn3DOGg-frHiuZIGnWws5xvTGBaD7ElCA0Jzl6YGNOo_5v5doyD7TZbdNjuwwmpCFTa3uTpcXqHUc70tL4K-YInKw5hc7WeCGIDmElIYwNpHILoRDCLODjJ0IsEUyUAOhElrdKIMkKZZTTL66oM5IIJdYQ1yOwVXzoVxqGvlpNLumuS1KmlFXCUeBnbNItZs8yCbhjklqqUBqT63VGMPyZNZ322656z9Od8EZ_y5iY-5zUofbLlo9lesxOFSnoQDcJNb7rRqfd6H4knA0bcTIt3G8kwIboNL2SYgWK4TIgngjpsKYXLgiwk_oI5aWv36vUDgOwHyQmqY8fMlnBmzzB2hr81z_fRe-nny_hRLmRErgaPZOSrGRPzDJPOAUm3k5AMsH0AmHZWUkSjgFJ2p2nlaHLmSJ14FlZLyBdc3M91AQkwXQUXgGnhEv8tYC1NH395AUm1PpOymyPZ_elONom1vvtSGdR--6eC_wFJsbFO
Screenshots

Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the leech calculation and comparing its current Path of Exile 1 rules with the Path of Exile 2 behavior described in the issue. Use the supplied build code and screenshot to inspect the discrepancy; done means the leech formula, life-pool cap, and stack cap match the intended PoE2 values.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.