PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding-PoE2

Make main socket group guess more fit for poe2

Open
#2,536 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
1.9k
Forks
451
Avg merge
21h 16m
Merged PRs (30d)
68

Description

Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/blob/ce566eac45ea8a86477f513c7ee65a1ebe60014e/src/Classes/ImportTab.lua#L1638-L1648

The current socket group guess function is obviously mainly meant for PoE1 since it uses the group size, but for PoE2 this isn't really correct since every group can be a 6 link. It would probably be a good idea to choose the main socket group by e.g. DPS, while also going through different skill sets. Especially some builds like the doedre's frog build have a useless curse as the first stat set which seems to confuse people.

Describe the solution you'd like

123

Describe alternatives you've considered

No response

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at src/Classes/ImportTab.lua lines 1638-1648 and trace the current main socket group guess, then inspect how skill sets and DPS are represented. Done means selecting a useful PoE2 main socket group across different skill sets, including cases such as the Doedre's frog build, rather than relying on group size alone.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
desktop
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.