PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding-PoE2
Banner Aura Effect increased mod is calculated as a multiplier instead of additive with global Aura Effect
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 1.9k
- Forks
- 451
- Avg merge
- 21h 16m
- Merged PRs (30d)
- 68
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
- I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?
Windows
What is the value from the calculation in-game?
In game my Dread Banner gives me 148% More Ailment Threshold. The base is 60%, so the Aura Effect in game is 148/60 ~ x2.46.
This is true for all banners and all of their stats.
What is the value from the calculation in Path of Building?
PoB pulled from the same character shows x2.88.
But if we just add all percentages that show up in the pop up window, we will end up with the correct x2.46.
It looks like the nodes that give Aura Effect to Banners like Knight of Izaro and Banner Aura Effect are applied as multipliers instead of simply being added to the standard Aura Effect.
How to reproduce the issue
Steps to Reproduce
- Equip any Banner skill in PoB (e.g., Dread Banner).
- Allocate multiple passive nodes that proive "Aura Skills have x% increased Magnitudes."
- Allocate a passive node that provides "Banner Skills have x% increased Aura Magnitudes."
- Check the breakdown in the Calcs tab for that Banner skill. Notice that the two modifiers multiply each other instead of adding together.
PoB for PoE2 build code
https://pobb.in/X__zHquFYvdW
Screenshots
In game:
In PoB2:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by loading the linked PoE2 build code, equipping a Banner skill, and reproducing the multiplier in the Calcs tab. Trace the Banner aura-magnitude calculation and compare it with the displayed modifier breakdown; done means Banner Aura Effect modifiers combine additively with global Aura Effect and match the in-game value.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100