PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding-PoE2

Supercharged Slam incorrectly taking weapon attack speed into account for attack/channel time calculations.

Open
#2,530 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lua
Stars
1.9k
Forks
451
Avg merge
21h 16m
Merged PRs (30d)
68

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

Supercharged Slam has a fixed attack time which is not affected by weapon attack speed.

In game my current attack time of Supercharged Slam is 0.58. If I swap to a weapon with slower attack speed, the attack time does not change.

What is the value from the calculation in Path of Building?

Changing weapons with different attack speeds modifies the attack time calculation of Supercharged Slam in PoB.

How to reproduce the issue

Open PoB, select Supercharged Slam as a main skill.
Observe attack/channel time in calcs
Modify attack speed of weapon
Observe changes to attack/channel time calculations

PoB for PoE2 build code
https://pobb.in/cdxajohLAj04
Screenshots
Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Load the linked PoE2 build code, select Supercharged Slam, and reproduce the attack/channel time change while switching weapons. Trace the calculation entry point for that value; done when weapon attack speed no longer changes the displayed time and the reproduction is covered by a regression check.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.