PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding-PoE2
Predator's Mark does not correctly affect persistent minions and can remain active together with Mark for Death
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 1.9k
- Forks
- 451
- Avg merge
- 21h 16m
- Merged PRs (30d)
- 68
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
- I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?
Windows
What is the value from the calculation in-game?
Pounce applies Predator's Mark to the target.
Predator's Mark causes the marked target to take increased damage based on the number of its enemies within 6 metres:
Marked target takes 3% increased damage for each of its enemies within 6 metres
Up to 45%
Because player minions such as Skeletal Sniper are enemies of the marked target, their DPS should increase when the number of nearby enemies around the marked target increases.
The mark should also obey the normal Mark limit. If Mark for Death I is socketed into Pounce, Pounce should trigger Mark for Death instead of Predator's Mark, rather than allowing both marks to affect the target simultaneously.
What is the value from the calculation in Path of Building?
There appear to be several related calculation issues with Predator's Mark.
Persistent minions such as Skeletal Sniper do not gain DPS from Predator's Mark.
Changing the number of nearby minions does not change Skeletal Sniper DPS, even though Predator's Mark should increase the damage taken by the marked target based on the number of its nearby enemies.
Living Lightning behaves differently.
Minions summoned by Living Lightning do receive a DPS increase from Predator's Mark.
This creates inconsistent behaviour between Living Lightning minions and persistent minions such as Skeletal Sniper.
The "# of Minions in your Presence" configuration does not appear to affect the result correctly when Living Lightning is present.
Once Living Lightning is enabled, its DPS remains increased by Predator's Mark even if "# of Minions in your Presence" is manually set to 0.
I would expect the Predator's Mark damage-taken bonus to change according to the configured number of relevant nearby enemies.
Predator's Mark and Mark for Death I are calculated simultaneously.
If Mark for Death I is socketed into Pounce, Predator's Mark does not appear to be replaced.
Instead, both Predator's Mark and Mark for Death appear to affect the calculation at the same time.
Pounce states that if a Mark gem is socketed into the skill, that Mark will be triggered instead of Predator's Mark.
Therefore, when Mark for Death I is socketed into Pounce, Predator's Mark should not also remain active.
How to reproduce the issue
Create or load a build using Pounce.
Add a persistent minion such as Skeletal Sniper.
Check the Skeletal Sniper DPS with Predator's Mark active.
Change the configured number of nearby minions/enemies that should contribute to Predator's Mark.
Observe that Skeletal Sniper DPS does not change as expected.
Add Living Lightning and check the DPS of the minions it summons.
Observe that Living Lightning minion DPS does increase from Predator's Mark.
Set "# of Minions in your Presence" to 0.
Observe that the Living Lightning DPS increase from Predator's Mark remains unchanged.
Socket Mark for Death I into Pounce.
Observe that PoB still calculates Predator's Mark together with Mark for Death, instead of replacing Predator's Mark with the socketed Mark.
Expected behaviour
Predator's Mark should consistently apply its increased damage taken modifier to the marked target based on the relevant nearby enemies, including when calculating damage for persistent minions such as Skeletal Sniper.
Living Lightning and persistent minions should use the same underlying Predator's Mark calculation rules.
The configured nearby-minion/enemy count should affect the Predator's Mark bonus correctly.
If Mark for Death I is socketed into Pounce, Predator's Mark should no longer be active because Pounce triggers the socketed Mark instead.
PoB for PoE2 build code
https://poe.ninja/poe2/pob/27a70
Screenshots
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the linked PoB build with Pounce, Predator's Mark, Skeletal Sniper, Living Lightning, and Mark for Death I. Compare persistent and Living Lightning minion calculations while changing the nearby-minion count, then verify that the socketed Mark replaces Predator's Mark. Done means both minion types use the configured count consistently and only the applicable Mark affects damage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100