PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding-PoE2

Inactive spirit skill gem (in-game) activated on import causing negative spirit balance

Open
#2,401 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
1.9k
Forks
451
Avg merge
21h 16m
Merged PRs (30d)
68

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

How is Path of Building expected to behave?

Path of Building should keep the active or inactive status of an equipped spirit skill-gem upon import of a character's skills and passive tree. If the player has deactivated a skill such as Herald of Ash, it should remain disabled after import.

How does Path of Building behave?

Path of Building re-enables all skill gems by default upon import. This can cause the character enter into a negative spirit balance.

How to reproduce the issue
  1. Equip enough spirit reservation skills to completely reserve a character's spirit.
  2. Deactivate one of the skills, but leave the skill gem equipped.
  3. In another gem slot, one that is not used by a skill reserving spirit, add another spirit skill with a cost sufficient enough to completely reserve the remainder of the character's spirit.
  4. Activate the new skill to zero out the balance of the character's spirit.
  5. Import the character into Path of Building.
  6. Check the entry for the gem in step #2 above to see that they Enabled box is checked after the import.
PoB for PoE2 build code
https://pobb.in/7m3OySb6VYtd
Screenshots

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Use the provided PoB build code to reproduce the import in Path of Building for PoE2, then trace the character skill import path and how each gem's enabled state is restored. Compare an equipped but deactivated spirit skill before and after import. Done means the inactive gem remains disabled and importing the build does not create a negative spirit balance.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.