PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding-PoE2

Verglas does not apply damage gained from destroyed Ice Crystal Life

Open
#2,389 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lua
Stars
1.9k
Forks
451
Avg merge
21h 16m
Merged PRs (30d)
68

Description

Check version
  • I am testing the current dev branch.
Check for duplicates
  • I searched open and closed issues and pull requests for Verglas.
What is the value from the calculation in-game?

Verglas grants supported skills 1% of Damage as extra Cold for 6 seconds per 2,000 maximum Life of the destroyed Ice Crystal.

For the linked build, a destroyed Ice Crystal with 271,990 maximum Life should grant 135% of Damage as extra Cold (floor(271990 / 2000)).

What is the value from the calculation in Path of Building?

Verglas currently has no effect on either the supported skill or Full DPS. In the linked build, Full DPS is exactly 23,452,423.18 both with Verglas enabled and with every Verglas gem disabled.

The exported skill data contains both the 1% per 2,000 Life stat and the 6-second duration, but SupportVerglasPlayer has no stat mapping, so the modifier is never created.

Using the expected 135% gained-as-Cold value raises Full DPS to 47,163,971.67.

How to reproduce the issue
  1. Import https://pobb.in/CI4hChFipObn.
  2. Select Falling Thunder and note Full DPS.
  3. Disable the linked Verglas support.
  4. Full DPS remains unchanged.
Proposed configuration semantics

Because Verglas is a conditional 6-second buff, it should not be assumed active merely because an Ice Crystal skill exists. A default-off configuration checkbox should represent having destroyed an Ice Crystal in the past 6 seconds, with a second input for the maximum Life of the Ice Crystal that granted the current buff.

The resulting gained-as-Cold modifier must remain local to skills actually supported by Verglas; making it a global effect would incorrectly buff unlinked skills.

PoB for PoE2 build code

https://pobb.in/CI4hChFipObn

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the SupportVerglasPlayer mapping and the exported skill data for the Verglas damage and duration stats. Reproduce with the linked build by selecting Falling Thunder and comparing Full DPS with Verglas enabled and disabled. Done means the conditional buff uses the destroyed Ice Crystal's maximum Life, applies only to supported skills, and is off by default until configured.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.