PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding-PoE2
Support Baryanic Leylines ascendancy notable
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 1.9k
- Forks
- 451
- Avg merge
- 21h 16m
- Merged PRs (30d)
- 68
Description
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?
MacOS
Is your feature request related to a problem?
Right now the passive notable isn't supported within the app.
Describe the solution you'd like
Without a major refactoring, I think the easiest solution is to add 40% increased versions of existing jewel radii, and when the passive is allocated, redirect the index of non-unique Time-Lost jewels to these variant versions.
Describe alternatives you've considered
No response
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the passive-notable definitions and the handling for non-unique Time-Lost jewels. Trace how jewel radii are selected when a notable is allocated, then verify that Baryanic Leylines uses the intended 40% increased variants without changing other jewels.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100