PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding-PoE2

Rage stacks on minions

Open
#2,348 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
1.9k
Forks
451
Avg merge
21h 16m
Merged PRs (30d)
68

Description

Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

I'm new to minion builds, but to my knowledge minions can have Rage stacks in PoE2. Adding the Rage support gem to Skeletal Warrior or Summon Spectre allows them to gain rage and gain more attack damage. Additionally Skeletal Reavers gain attack speed (and they can gain Rage without support gems with their Command skill Enrage)

Describe the solution you'd like
Image

There already are minion-specific configuration options. A similar option could be added for Minion Rage stacks. I suppose this might not be that simple as some minions might have Rage and others not, but adding a Minion Rage option that assumes every minion has that amount would still be useful.

Describe alternatives you've considered

I'm not sure if Rage can be added with Custom Modifiers. I managed to add Maximum Rage for minions although I'm not sure if it even really counted them. The popup says that the modifier exists, but Maximum Rage is still 0.

Image
Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the existing minion-specific configuration options and the Custom Modifiers entry point, then compare how Rage support gems and Skeletal Reaver's Enrage are represented. Done means minion Rage stacks can be configured and their attack damage or attack speed effects are reflected correctly, without assuming every minion has Rage.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.