PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding-PoE2
Herald skills should not have a buff subskill
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 1.9k
- Forks
- 451
- Avg merge
- 21h 16m
- Merged PRs (30d)
- 68
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?
Windows
How is Path of Building expected to behave?
Herald skills in poe2 don't provide passive buffs like in poe1, so they should not have a Buff subskill.
How does Path of Building behave?
All herald skills have a Buff subskill which is afaik completely pointless:
There's also an issue with the quality being added to both the buff and explosion subskills:
How to reproduce the issue
No response
PoB for PoE2 build code
Screenshots
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named. Start by locating the Herald skill definitions and comparing their Buff and explosion subskills; verify the expected PoE2 behavior and how quality is assigned. Done means Herald skills no longer expose the pointless Buff subskill and quality is not duplicated across subskills.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100