PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding-PoE2

Weapon sets for skills with updated DPS calculations

Open
#2,167 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
1.9k
Forks
451
Avg merge
21h 16m
Merged PRs (30d)
68

Description

Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

Yes, the issue is here when I assign weapon set nodes to my tree my calculations do not change, whereas they should be. This is because my skills are not assigned or attributed to weapons sets which is also what is causing these two errors

Image

These two issues is because I swap between active spirit reservation skills when I switch weapon sets, so for example I need to be able to distinguish in POB what weapon sets these are assigned to, for example my Herald of Ice is on 1. When I am using/allocating weapon set 1 I need to see the Full DPS calc for weapon set one changes and the Full DPS for weapon set two changes. This is the only way I can properly theory craft my build involving weapon sets otherwise POB proves pretty inadequate for any trees that have weapon sets in mind, which is nearly all builds...

Describe the solution you'd like
  • I would like skills to be able to be assigned to weapons sets
  • The tree to calculate Full DPS power report by weapon set/group of skills instead of me having to mark relevant skills as "Full DPS"
Describe alternatives you've considered

None yet I cannot find any good solution for this issue. I also think this is one of the most pivotal core issues missing from POB when it is one of the biggest game mechanics that needs to be able to be calculated and more effectively interacted with in POB.

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are named in the issue. Start by locating the weapon-set tree calculations, skill assignment handling, and Full DPS reporting; done means skills can be assigned to weapon sets and DPS reports calculate per set or skill group without manual Full DPS marking.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.