PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding-PoE2

change coc cast speed calculations

Open
#2,166 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
1.9k
Forks
451
Avg merge
21h 16m
Merged PRs (30d)
68

Description

Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

cast on critical/ ailment is going off of the socketed spell cast speed instead of the skill proccing it

Describe the solution you'd like

it would be cool if you guys tied the cast on critical/ ailment casts per second to whatever main skill we have added to full dps. since there may be more than one skill i guess it would make sense to have a checkmark box for every skill so we can manually set which skill is proccing coc. just assume we are proccing it every cast for now so you don't have to mess with energy gained calculations

Describe alternatives you've considered

No response

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the cast-on-critical and cast-on-ailment cast-speed calculations and how the main skill used for full DPS is selected. The change is done when these casts use the selected proccing skill's casts per second, with a per-skill choice available when multiple skills are present, without changing energy-gain calculations.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.