PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding-PoE2

Adding uniques from built-in list sometimes loses mods

Open Beginner friendly
#2,156 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
1.9k
Forks
451
Avg merge
21h 16m
Merged PRs (30d)
68

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

MacOS

How is Path of Building expected to behave?

When using import from built-in uniques list, all mods are kept

How does Path of Building behave?

When importing an item where first mod is unsupported and there is no implicit, then that mod will be lost. I've found two such items: Opportunity, Ultimate Life Flask and Lavianga's Spirits, Gargantuan Mana Flask.
This happens only with items that don't have an implicit. For example adding Zerphi's Genesis, Heavy Belt works correctly

How to reproduce the issue
  1. Go to items tab
  2. Select uniques for "Import from"
  3. Find "Lavianga's Spirits, Gargantuan Mana Flask"
  4. Observe that all mods are present in tooltip
  5. Double-click the item
  6. Observe that the first mod is lost
PoB for PoE2 build code

Screenshots
Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue through the Items tab using the built-in unique import, especially Lavianga's Spirits and Opportunity, and trace the item import path. Done means unsupported first mods are retained for uniques without implicits while existing imports such as Zerphi's Genesis continue to work.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
desktop
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.