PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding-PoE2
Incorrect Calculation of Attribute Requirements for Support Gems
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 1.9k
- Forks
- 451
- Avg merge
- 21h 16m
- Merged PRs (30d)
- 68
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
- I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?
Windows
What is the value from the calculation in-game?
No issues in game. It allows me to use all the support gems for the build linked below.
What is the value from the calculation in Path of Building?
For the build linked below, PoB2 shows a warning: "You do not meet the Strength requirement of your total Strength support gems."
This is because Weapon Set 2 has a weapon with a granted skill that uses a red support gem. Set 2 tree includes an extra Str node to cover for that. But PoB2 does not account for it.
Fix: Calculate attribute requirements for the two weapon sets separately and show separate warnings for them.
How to reproduce the issue
No response
PoB for PoE2 build code
https://pobb.in/1oMAVH1Zttgz
Screenshots
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the attribute-requirement calculation and warning logic, using the linked PoE2 build code to reproduce the mismatch between weapon sets. Trace how granted skills and support gems are included for each set; done means the two weapon sets are evaluated separately and warnings reflect the requirements of the active set.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100