PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding-PoE2

Tempest Bell implementation

Open
#2,123 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
1.9k
Forks
451
Avg merge
21h 16m
Merged PRs (30d)
68

Description

Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

As of now, Tempest Bell's Shocwave part is just in-game damage number with an unrelated(?) attack rate

Describe the solution you'd like

Tempest Bell shockwave should be

  • Included as a buff to other skill (such as Whirling Assault) to calculate it's hit rate / Bell
  • With 0.3s cooldown
  • With 30% elemental increase per "Is enemy X? (elemental ailment)" modifiers
  • Average of 3%/hits it can take increase (15% at base 10 hits)

Possible more complex implementation of the latter:
3% * (Bell Duration / Skill Hit Rate/s) capped at Hits Before Destroyed
either an average of it or a range

Describe alternatives you've considered

No response

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are named. Start by locating the Tempest Bell and shockwave skill calculations, then determine how buffs, cooldowns, elemental-ailment modifiers, duration, hit rate, and hit limits are represented; done means the requested behavior is reflected consistently in the relevant calculations.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.