PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding-PoE2

Strange poison dps calculation with `# of Poisons on enemy` setting

Open
#2,102 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
1.9k
Forks
451
Avg merge
21h 16m
Merged PRs (30d)
68

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

How is Path of Building expected to behave?

When I have max poison stacks > 1, and 100% uptime on that number of poison stacks, I'd expect the # of Poisons on enemy (if not average) setting to default to the average, like it says.

How does Path of Building behave?

When using a skill with a cooldown, there's something wonky about the calculations. To reproduce:

  1. Add Explosive Transmutation
  2. Add the following custom modifiers:
100% chance to poison on hit
targets can be affected by +1 of your poisons at the same time

Since this skill has a cooldown of 0.5 seconds, it should guarantee a 100% uptime on max poison stacks (you can verify this in the calcs tab, the avg ailment stacks is 2). However, if you set # of Poisons on enemy to 2, your dps decreases. If you keep increasing it to 10, 100, 1000, your dps seems to converge to some value, so either the calculation is broken, or the label is misleading and it's something else entirely.

Now the reason I wanted to set this value to something specific was another support, Arakaali's Lust. I correctly get 16% more damage with the setting set to 2, but then it messes up some other part of the calculation.

How to reproduce the issue

^

PoB for PoE2 build code
eNq1W19z2zgOf24_hcYzdy83jf8krt2eszuOnTSZSRqfnXbvnnZoibZ5oUQvSTnxfvoDSEmWbMuikr2dzlaW8ANIEAABkB38-hpyb0OlYiK6bLTPWg2PRr4IWLS8bPx4uvnUb_z6y8fBhOjV4-IqZhy_dH75-GFgfngbRl8eREAvG3cPk8fpU8PTRC6p_pmybP3ebnghYdFM-M9Uf5MiXoOghudzotR3EgJ0SqIllQ2P0w3l9uOKSOJrKu_x1TDWwgrRMqYNjyifRsFox-C7iGgDBvVhMOFkS-VME-1tCI_h2-feWff8y3mv3-596X0-b3gKPl42hjBpsqS3TDeab0JexVLpMQnhsZRDK8XM1pQGpWTti5RuIun1YkF9zTZ0JJkerUjkUwegA3EnT_sQc83WnIHaS5m3suHfVjLPSJ-EJnw8mblSCl1N-RvTqysOGnTii9R3y4hpeor8S__s4svnTO-CKRG506OMuph0vk6TGMWcg6c50U6ponJDNKszmpEI5yyqUOlZd0cueCBeonJrOetnDiIpeVxYO56SgMXqgWpJVfVMHkhERkJpN8oJlRAHdC3AjPoCQkddGTWR92xB3SlrzSMB1B3N2-ZxPXOlq834bQOaQrR1o5yJmJ-k7GWU-kQMzBxgTF9Lqbo7T_zjFF0m8i5ymMGYbgT6tEMklWwe6_LgfNE763X7ndZ5p9PpX5wXAtL17aR8A8wmNlltFfMJfyCvLIxD2A-eyDMtH9pOyD1brnQEoaw-9IZJWh81gkDlitpNELY3oVxhuyUi8jmiSrnGaAi3VYjdkNBtq00OMgv_K5LeRb4j0x-RTEbjCJiCh2LSM-fUJVsoykgc3S1MTemSRom4rRvknlJ_9Q0SzCk54QLdQlR3Stj8r0h6Sq1Fpg5qzSmpiKhSUicPq6kkhLgpKTe82ZrJE6lxb4_QYe7lEGcLuY6oXG5nK0Z5UI861daIrB3XPo8-ZQMl4mqtUB7qtlKFDdFNWrb5XG-IctpWrB4stZsKNiSgroXCA4WMvhZiIsV_sTTi9WAwDc7rI94obUwXHGECFxC2PWeEq4ChDEUsHVfPEjstXrrF25J2SoPYd8s-soL1ikOJ7zqNDGWUXQs61Jr4z2MRLOutaC1EcXyzeL2GcIWeUMHg025TwPwF9n3mkq7uaB_Bi0-FqZwATHVcBexoawjIkjdXKXuAKlGtQvrlPJUdcZWA9sFyPkCUDGG3MR2ZB1G-j-R7MorCktcrZW-ggHeq3g2hY1dgIl5gvivssJUP4fwYNaS2DkORNPpz68y_QO4k4DoKYonu4yxjH7ETcxUvFsrzRTgn-h5M4bLR8ObwLn32Y6lo8sMinlgIe45SY6KJpyiR_gq_3xDO5xBQELR7i7-CpAL7SSQjkW4be9p72cGXyH_QNB1RfHqSlHokjR4-UpgB4A8vEgFVmDtedL8UWpl3gdGU6YtCgUhlRDi-66RUoIZt_gP2VRX83FrjVvgGjJPmeq_dlJ_lo0ypTeR2WBQbMW5G-GHwY3pvHj6stF6rr83my8vL2ZrolVjQV9gLz0DhzTXAYG6f1DPj_BOKbA7hv6vlHf41NIyaKaeBbfyqpv2FHisZqMCKGUAwt9Vr-gEU_Prd6giNQGbPLNLpc8KrWWA2aKJ-zUrgAuDDDAeoPLUSL_d0SfztNxoCfkG4oriSCxJzDe_ubeM5EjLMalwQLiR-VFdbcM4bTM6KbbMcg3_FhDO9taaeh2Uta2sNOJ4Z1TYwwahwX7HkT9s1Tm14f5_YSkLqsSC1n-Sl6aYPd_xGhPvKLC8nc5wGqsrncQAlYRKF7Ap7NMISLkjHtMcHWSSLAuPxIhIm1nv9uuYCF9x7AldUYaxNrxFMS0gZr3WivVb2AkUkOrYiv3ExJ7ydCs6_7KQvN9af0BwzgXvy9sa_pCFSQ0QmAbh0806D1puo-qaZEDyVcTKWWy7KBqSG90duWX0RR3bhkmOKTiuxw319DSV5JgD8O1kL9U_l3cewq_3flJVKUygmsSd3VTV3FlhglFNRQlH47KSgduanZjkSH03s2vip9U98HIlowZaJm9gfiZ8YWPam4A530TrWGCPMaRVUr3_DgyPYLDwtvLVpz3vwZ8X0R3sqBfsFibw5BGcTMWngzbfeP9qeWHhbyJMTjPJgI9Ir6ilYUk_DrtEwq3vZ8GHqIoSsQaVTs0OI4nBOpfFBSxhmxyv2lOAxghov3KYoUJ9PV5CRUZlhz1spmCIpHtLkT5eOg9opRrEl448Ls-XDRprtrcdhX7C_kxNWzP3rILOErxra3ZvgXvLqJg_z5GpR5_3PRVmYMVbDWoeg6hF2DtcNVfkbJabRN8Na5eRinB-oZZL2Hl0AqJEKQL_1uYjJ15AlhtXuFRVf6BqUYFqtQ_sfxRLSRH3Yuinh0T1kgYdtVNLAqHKEUWZG-eL0SDKPhXyHYUgf2WgLljqS22oPyRxrtoL0pXoRd_QQ1v1VDUBunpB7yu0PRbFdBTrjJ-NFv1N0RIy5Nex0DGa9K2SdxzhmEDlxQYdhKND0grcy-Ab_IwF15zFa4c5Rqdje3jxtO0Nwbm4ZuPtVFtkqnGsvrB0tmZ2Q--2CKtMOaCiiG0hZ32RsMx1HkZul7cdgDFHVwbTXKk4vdwWiRB0HcbTQamlmOYBJHeyvtNr6yeiL96cQ4b8vG5_6ve5Z56LfPe_BLoAv_wMv253O2UWvd9Ht9NMyb6alqTEwD4e8L7VMH_NwmzYhOEnY2jbbG5jMKclT8LmQzR_nEitqzzhhT1iLyCDSimuQ8EjymlJaSEM0p6ZZiCVHWg9wAUjgMJlDuWUyf20zvUz3lo_X9mYvaZ-kDq7zRly7BmQIVkl1DcAt5WEtQDqZGpArEWy94j7pgII0fbPbWJzECF2HfgqRpZZyDaBTF3BeZwqU11kLKMRrjQfpa1mTDGvxR_o6_G84Uc-1JFhEHRnY7AprLYJFdGoj2ml0TeKQia0mxpmqDFsLNkwV6pxd2YEF3O_2dcKpWJRd39xcj57ufl5nOxBT_u_Yp8MLfQlkZg9MTAxM6kM8EcGSknOyVrkSWcVzZakvGxj0DfkYylrG1RFut1kRVcHL8LktllwFTiY5Y-DbFYyuwzXWYCZb1ceGhDfeXAZjR4Jneti3PKYps6FWsLJnJSOidO48Mc8F99kqJkhzbCp34ZrwStUmVCVLjX0vqyoXpWjskq2pzxbML1Pw7rJilW58P5bE3x7hYW4bVuEt0SHYlvxV6ITqiFbN3cVKrVqqI_ZFfbKtQluiQ3B2-lzFICMU0e4KbZ7TNadDxvGkpXJlv4vIGDsEjAxyyPABAkfS6K5i-Ij1Ykp7yClrOSsH70kpj-gK7-dUqWl3h6cwF7yDUgHN3VMpej1z8NjC9Y3CsuTr8KpQdnjdIs8qqVUqmFiqo8tgk6uqJcgfdxdmkjQkqiZRuO1QcBQTYIcbwQKXaLFP_m6G5sz7LxgXnmr_BWyyewtHeJkMptJbEionuK2M8ugfmmEr-X1M0N_exwHd7n0cTGJ1DD3dz0MOsdPjyUd6XFoteHk0VLnhs7PWN3OwJ8JvhpvudUnoB_s0RbVT7M-I38cLeyRjUEmJV5SyOpyZGdWp2FGbl90oT0zU-r-9yOoU2vJ3Xt_DCLbx2-P5Yg1O2X2NW0o4_lsLwd_H8PjdXhdmR7yU-iJekyhIuT2WZ-l1tCe0AqbmGsEY7_Spd43SnDjl-AyaaTk3mBCpt95sJV6GwQYt8gn0mz8YV5pFJNmAOW94ZL2mUTZq2wgL8VTQo6_4l2FY-PxdaHssj4KTH4Pmwb8j-x87C8LT
Screenshots

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with Explosive Transmutation, the listed custom modifiers, and the # of Poisons on enemy setting. Start in the poison and cooldown calculation paths exposed by the Calcs tab, comparing average ailment stacks with DPS as the setting changes. Done means the setting behaves consistently with the documented average and Arakaali's Lust still receives the expected modifier.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.