PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding-PoE2

Take account increases/decreases action speed and specific slow effect when calculating the skills movement speed in the sidebar.

Open
#1,797 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
1.9k
Forks
451
Avg merge
21h 16m
Merged PRs (30d)
68

Description

Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

For example with 100% movement speed (the base value), while chilled to 30% and using a skill with a 50% movement penalty, I end up with -50% Skill Movement Speed on sidebar, i was expecting a -65% (100 * 0.7 * 0.5).

Movement penalty when using a skill does not take into account increases and reductions of action speed or specific slow effect (Chilled, Temporal Chains) but take into increases and reductions in movement speed (and movement penalties related to armor/shields)

Image Image
Describe the solution you'd like

I haven't been able to verify the exact behavior in-game, but they are certainly taken into account, otherwise we could find ourselves in a situation where the movement speed of skills is greater than the movement speed. Since the effects of slows are multiplicative (according to the wiki), we can find ourselves in this situation with the debuffs Chilled (50% reduced) and Temporal Chains (30% reduced), which should result in 100 * 0.5 * 0.7 = -65%, while the Skill Movement Speed ​​would still be at -50%. This can lead to things like this in PoE :

Image

Two other points I would like to mention that are more or less related to this request (please tell me if it is preferable to create one or two other tickets).

First, slow effects are not multiplicative in PoB (contrary to what is stated on the wiki: "Slow effects are always multiplicative with each other").

With the "Chilled" debuff at default magnitude (30%) in the configuration panel and "10% reduced action speed" in Custom Modifiers :

Image

The slow effects accumulated when they should have multiplied, the result should have been x 0.57 (1.3 x 1.1), if I understand all this correctly.

One last thing (and then, I promise, I'll leave you alone!):

Image

I wonder if it wouldn't be more sensible to perform the calculation here that yields the result shown in the sidebar; you're in a better position to judge. I simply wanted to point it out, just in case.

Describe alternatives you've considered

No response

Additional context

I sincerely hope I'm not saying anything incredibly stupid, in which case I apologize in advance... Thank you very much for your work !

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the sidebar Skill Movement Speed calculation and the code that applies action-speed changes, skill movement penalties, and specific slow effects. Compare the calculation with the chilled, Temporal Chains, and custom-modifier examples in the issue. Done means the sidebar reflects the intended slow-stacking and action-speed behavior without making skill movement speed exceed movement speed.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
desktop
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.