PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding-PoE2

Update non damaging ailments (Shock, Chill, etc) to PoE 2 Values

Open
#178 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
1.9k
Forks
451
Avg merge
21h 16m
Merged PRs (30d)
68

Description

Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

In PoB 2 the ailments aren't calculated correctly.
See https://www.poe2wiki.net/wiki/Shock and https://www.poe2wiki.net/wiki/Chill
The new values are 20% increased damage for shock and 50% for chill. There is new logic on application chance as chance increases and isn't guaranteed on crit.

There is also a bug where it seems Lightning damage isn't applying shock likely introduced in one of ailment PRs.

Describe the solution you'd like

I would like the chance calculation to presented similarly to how effect is currently presented and the values updated to poe 2 values.

Describe alternatives you've considered

No response

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the Shock and Chill values and application rules with the linked PoE 2 wiki pages. Trace the existing ailment effect and chance calculations, including the Lightning-to-Shock path. Done means the displayed values and chance logic match PoE 2 and Lightning damage correctly applies Shock.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.