PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding-PoE2

Active Gems Contributing to DPS but not sorted for DPS

Open
#1,633 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
1.9k
Forks
451
Avg merge
21h 16m
Merged PRs (30d)
68

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

How is Path of Building expected to behave?

If an active gem contributes to DPS it should have the green plus next to it like some other gems do.

How does Path of Building behave?

Currently on a crossbow build Oil Grenade has a green plus because it contributes in my case 700k to Combined DPS which I sort for. But explosive grenade doesn't have the plus even if it contributes double the amount.

(obviously I spiked the custom modifier to check if there was perhaps a min value under which it doesnt get a green plus)

How to reproduce the issue
  1. Add a crossbow to mainhand
  2. Go to gems tab
  3. Sort by Combined DPS
  4. In search click A for active gems
  5. Notice 1 skill with green plus out of the 12 that actually do.
PoB for PoE2 build code
https://pobb.in/7AYn7ekqNYSs
Screenshots
Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue from the Gems tab using the linked PoB build: sort by Combined DPS and filter for active gems. Trace the logic that decides which gems receive the green plus, then verify that every active gem contributing to the selected DPS sort is marked consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.