PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding-PoE2

Fix issues loading old GGPK data in the exporter

Open
#1,556 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug technical
Dominant language
Lua
Stars
1.9k
Forks
451
Avg merge
21h 16m
Merged PRs (30d)
68

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

How is Path of Building expected to behave?

When swapping the current DAT source in the exporter, we should be able to load old versions of GGPK data

How does Path of Building behave?

When we changed the path from "Data" to "Data/Balance", we aren't able to load any older GGPKs because they don't have that path available. In addition, I believe this section ends up overwriting the spec you're trying to load with the currently loaded one instead

How to reproduce the issue

Have a body of data saved from before 0.4.0, including spec.lua, data, metadata folders, etc.
Create a new Source in the exporter with that path, and switch to it to see no DAT files loaded.

PoB for PoE2 build code

Screenshots
Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/Export/Main.lua at the referenced lines around 380-384 and reproduce the exporter behavior with pre-0.4.0 data containing spec.lua, data, and metadata folders. Done means an older GGPK source loads its DAT files when selected and does not overwrite the selected spec with the currently loaded one.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.