PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding-PoE2

Black Doubt's sacrfice mod should be unscalable

Open
#113 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
1.9k
Forks
451
Avg merge
21h 16m
Merged PRs (30d)
68

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the behaviour in-game?

Unscalable

What is the behaviour in Path of Building?

Scalable
image

This is caused by the stat description being a multiline mods that covers both the Dot line and the sacrifice line, it is not a simple to have entry for every new line in modScalability but a potential solution that could work alright was to assume a new mod has to start with a capital or number which probably will handle most of the cases but might introduce some garbled data into the file.

How to reproduce the issue

No response

Character build code

No response

Screenshots

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the stat-description parsing and the modScalability handling mentioned in the report, especially how multiline mods are split between the DoT and sacrifice lines. Confirm the current behavior against the Black Doubt sacrifice mod and make the result match the game's unscalable behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.