PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding-PoE2

Skill effect duration with buff expiration rate, incorrect behaviour

Open
#1,021 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lua
Stars
1.9k
Forks
451
Avg merge
21h 16m
Merged PRs (30d)
68

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the behaviour in-game?

"Buffs on you expire X% slower" mod has a separate calculation and is different from "Y% increased skill effect duration". Buffs on you expire X% slower is a multiplier to Y% increased skill effect duration.

What is the behaviour in Path of Building?

PoB thinks both of them have the same effect and are additive.

How to reproduce the issue

Add something like Bone Offering or Encase in Jade to skills.

Allocate Prolonged Assault and its small passives, which in total give 32% increased SED and 10% slower expiry rate.

Check duration mod in skill type-specific stats.

It says x1.42.

The real value should be 1.32/0.9, which is x1.46.

PoB for PoE2 build code
eNqlWlt34roOfp75FVl57pRwa2EWnb0o0GnP7oUN7czZT7PcxIB3nZiTOLTsX38kOwmXwalD-0CTWJ8ky7IsKen98RZyZ0XjhInowq2feq5DI18ELJpfuE-PV1867h_fPvfGRC4eZpcp4zjS-Pb5U0_dOJyuKAdgw3V8TpLknoT0wp2QaE5j1yGJT6NgsBm4FxF1HUniOZU_cqnerzqgFyQmvqTxLXLsp1LciQAQMk4BERIWTYX_QuX3WKRLEOg6K0ZfNc3N3fhh8uiCVp96Y07WNJ5KIp0Efi7cPsyOzOk1kwAhPAV6z62V0l6mcSKHJITL9zHTJaVBQdY8bW7_mUCDmMm7lEu25AwNlaEbJnrQfrAgkb_Rp-4ZNXoUkvDhePq-7ppSWFjmJ5OLSw4zteKL1DfziElqTT4WLBFRJa2tiAcp5-CyVrQTmtB4RSSzVGQgwmcWWdrkjkRkIJKNrevtMtIxjWHvyB2E9w5gSn0B220b0vYshByGGpG3bEbtKStNJANU1ea4eYymtnSVGR-n0AQCjh3lVKTcklJuwkvLGF-G9M3CL2-ijcBzM6uVwB1kuY9H1-NN-Ku3TluNs9aZ12h2G0YJ48U6YT7hd-SNhWkIsfGRvNCNwMb5udlZ5gsZQTwwYevdjgl7xWJ6BGwgeHAMbEFEcsQMhyR-iWiS2EY7iF7WCNxqNjrAkeh_ReKbyN9EojKuT1GcaWO3ijM6gX2Fp_Uzp7aQjZBse9ocplrWnEaZwLWdmW4p9RffIWuZEEntAnhB1W2UGhZptw1byvSAYc3sdwEVjITAw0Zqnp6XgSqaabpkMbPSSFMemH0FTAUDjCIaz9fTBaM8sDgftqhziw3I0irX9L9uo638YFdcJVfehlZcKzzMqkpbkWT75DjvlhtCk9vtBQrJKwACupdHGxHjWPxDfcl4NVg_DkUaWy6lJraaQH7o6bJkQoPUtztlR7MZTmNFLzkUULbTKFCgJ-eVoH0pif8yFMHc2mhKSCXErn7TdLmEXYveYMsAT3M4AdlWDvWlZUH9AK5stVfx3LcXsKG2FlDkMvZS9iD2c8FkZE-MDbG1gGI57yBUhBB0VVUN1f0m-BqXBgo8qwJMEVpWjWPxCpovsE-RVKOGlG1z-BlViWn079qa_w65lYBRFKQxbgRrGfuIQ2Iu09kscXyoeom8heW9cF3nGZ7l134aJzS70YhHFkLgTZIhkcQJssrgB4kZiWRDdXESSmJ_gaArwvkzRA7ktHmKd3vAeu4NvZpqQuHVTbgUsXToG_4bk1iuL9wZ4QnVhOoJ8Ekki1R9D2GKc9eZLsRrP1jhvB-F4EkOcshySaNgh8djTKlD8qDjoxJqjnjjhCSRcMZpP05Q6a3e102AhnciAQpAFdZpefWTutf1uidtr9XunjTOzjtnJ_Vmp9E5aXqdhndSr7fgp932zk_q3VarcdLqtM86J_WzVgfI2_VzD22ElSWJ1_1dSRGDiUlQdqvBlrfntCao9qfe0-RWXXxaSLlMvtZqr6-vp0siF2JG3-DYO4WFri0BBBP-krwwzr8g11of_i7n_f7g3Jv8uawL8c_fI_r9r1EwXD9Of_3ZTUeXy7_5DVBdXChBtVxST7fwkpq-w-gQM7CJVqMHB0fMnlNJ8wFYsLd7bTTXYZEsrhMZ3_9uTG0vbczMXsqMaDQ3k1nbEdqr4eIpT8LVxYt7IfUYPsxvelOcfuIk4FzfaZhcriGKXGFStNcEytwDqadUagffxuT9zIDOSMrx-V8p4Qy91dt-eqvbqpGIw6LOBVbgrXjUaY6P6yVaoH97m_lhJtVhQe6b2UPVPu1vVBsQ7idKORb5PA2gTsuiaOY9nDyjeOwFY4EVbLdht_gUYj71QJ-M-DsXz4Q3ckjWIG547s54PR9f6T2Njqn9GPbiehT5JKGQ3f4HMi-YNwpDCv1cP9YRzHX-t2XAOQ2R7I5KEkDEqd1IMHwNdKspfeHCKCMiYbat9QCYxtEjezbwRRrJ4jxCF0LWmTdlS6A8SvsMXip7K4qbaJlKJevCDVni_8LwiU1s5dOq6T66uhoNHm9-jLIQug1RhvgVpeEzzlz_3xyNU6pSQidJnxN9eeH-YPRVKTIEmzCeoP6ck2VCi-Cm_CXTnAOuhJuiumZFb_wwrw2BmdPojcYQi-c_Ic7HjBr1KsbfUUoLxDoDjxwTN2x1mxnpxHUAkVxXOAZLqX6_mQu29o3TwcESLJxihBslZ6PvWEJiWABHZjPm4_levuQYRDRViV18ONiJvy5Z7yzrNvNQ7w5MDPSgGazfDZjQ2WiJVdWbCKNV9agZPqQ-Mc5dD5rBRdEsIvUG6jCXgqqE072IlJPDpukzjjmycWVHnBYkZoYPckHjLGExcbqDGJWTlG4cfXAb-WxRlNhKtRcNFsIxM1T3zwxzwLGSTZP1lEy7nZVv2d3Oj2E9tmnMrHTNZLRhVn-VLEPWejAsgR4tmUnefTFMIhsu2SgqBvdXggW6BjdsmT2ysqAB-eLH2ajGwsfZ7HcaPs7xClLyF-N6Z6Nm-JNkmPkc4KIzFSsmuLE-xgH318c4YMkZHo2e7KciG-ykPAkpiuOD4Hy0bO9nNfPRHHRlfzRcNR6ORqsDYEhnFGZQegIUNCWbQ6bREIwhSzaGJSul1uEospldJV76LDw408oc9e7OXseVBQBN8g4jOMyvS9JFO05F8-yaEo5fUgj-MYa_vXb8CDNs_6dLEgU5u4dDSfpmHSytJ2QCPFX_Z4hvGT5qw4iG6wOMzHr1anlZpzpDWGhlbaupjLF2_leI8O8L90vTOzs9azaa7YZ-ltX23ayeh-R7yGAFY-V5uUQk_C_2cjsA7na7XksLVRVt1mbA66LLYGaVJlR_hPCTkqWIFAKrfF1dah5Got1mAhfSgWQ5HD8_TW5xjroshZJ-hfsKh3SHqVYO0EKcenVIowJkArvLaVYAXAohj5mGM33FJrc1rh-mnMqqM6kydXWiVpq7RlSXccwaVrXXJeVVrKUyhkqKXVM4ISovSL2SawVrJ0_QK87k90Xp1bJ9q-KQigmqzySiGZtn0UHfZPFBgYonO5t6zIlPF4IHNM6kUoyF2WeNeY_p3CuUNQB23hHlsPdAxQupvKOUA7tn7ffkxZtvInNUCWa6gFpiig2e5LfOmVkGPKmuGb4srI5Sx8IG0GmY6cPiy1H8chLCfaAmNsDO5JTy2dYE2xYz3F-0tvWqjTE5yGFNW1RleUVlWhin9Z6w3dfllfwK_Xgf1uyc2SwHZsERxW86IN_ka3tHG4JBdl254VmsXCX744ZBk0AUVt977W-GMolbHocN2fVTcswst9-52yz-1Bcqnaq4aeNNg7qwzXvWzENz4WHeWYk9EzZn_GGmyi9QT9WQ1kutP-CAFFN9Jb8dYi3MZ7vigwX28w9bDjLX_CTQeay6-_a5V_vtM___A9Xvm70=
Screenshots

Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with Bone Offering or Encase in Jade and Prolonged Assault, then trace the skill type-specific stats calculation. Compare the displayed multiplier with the reported 1.32/0.9 result and verify that the two duration modifiers are handled separately.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.