Fix some Smart Linking quirks
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 66
- Forks
- 36
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 16
Description
Describe the bug
Smart Linking has some quirks. Specifically:
Quirk 1
- If we ask for Smart Link suggestions and press
Rejectfor all of them, we finish with an empty left-hand list the dialog:
- In addition, if under that state we press
Accept, the suggested Smart Link gets added to the content.
Quirk 2
Let's say that we generate 2 links for a Block. We accept the first link and we reject the second. Finally, we press Remove for the link we've just accepted. We'll get "Successfully added 1 smart links." notifications.
Quirk 3
Not really a quirk, but something which can look like one. When we've only got 1 suggestion, the Previous and Next buttons are still being displayed, and they aren't visibly disabled (although they don't work, styling remains the same).
If there is no way to have a visibly disabled state, I think we could hide them when only 1 item is in the list.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Smart Linking suggestion dialog and its handling of Accept, Reject, Remove, Previous, and Next actions. Reproduce the three reported states, then verify that an empty suggestion list cannot be accepted, removed links do not produce incorrect success notifications, and navigation controls are visibly disabled or hidden for one suggestion.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php, wordpress
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100