Parsely / Parsely/wp-parsely

Consider using no-misused-promises and no-floating-promises ESLint rules

Open
#2,732 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

wp-parsely
Dominant language
PHP
Stars
66
Forks
36
Avg merge
2d 2h
Merged PRs (30d)
16

Description

Is your feature request related to a problem?

We use promises in our code, and maybe the no-misused-promise and no-floating-promises ESLint rules could be useful for us.

Describe the solution you'd like

Add the above rules to .eslintrc, and see if it would be beneficial to use them.

Additional context

To be added in .eslintrc, under "rules":

"@typescript-eslint/no-misused-promises": "error",
"@typescript-eslint/no-floating-promises": "error"

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the repository's .eslintrc and inspect the existing rules configuration. Add the two named @typescript-eslint rules at error level, then run the project's ESLint checks and review the resulting violations to determine whether the configuration is beneficial. Done means the rules are configured and their impact is understood.

Written by the indexing model from the issue text.

Assessment

Tech stack
eslint, typescript
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.