Simplify PCI imprecise number functions
Open
Nobody has claimed this yet.
Maintenance & Fixes
Refactoring
wp-parsely
- Dominant language
- PHP
- Stars
- 66
- Forks
- 36
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 16
Description
Is your feature request related to a problem?
We've got a PHP and TS imprecise number function that we use for PCI. These were ported from the respective Parse.ly dash code in order to have identical results between dash and PCI.
Describe the solution you'd like
Check the discussion here and see if we can have identical results to dash with simpler versions of the functions.
Describe alternatives you've considered
Do nothing.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the discussion in pull request #1860, especially the linked comment, to understand the proposed simpler implementations and how they should match Parse.ly dash. Compare the PHP and TypeScript imprecise number functions, then verify that both produce identical results to dash.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php, typescript
- Domain
- analytics
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100