Git file patches don't work properly when rebuilding/applying
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 317
- Forks
- 76
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 5
Description
I discovered this bug when playing around with file/git patch conversion
Turns out that when you try to rebuild patches after changing the gitFilePatches to true property in the fork-server/build.gradle.kts when you try rebuilding to convert your patches it fails on the apply* tasks
Example output of the error:
I assume this is a bug since when using -x pufferfish:server:applyMinecraft(type patch)Patches it rebuilds and converts them to regular git patches properly, however it doesn't occur when going from git patches -> file patches in my testing
this was first brought up in the #build-tooling-help channel on the paper discord
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with fork-server/build.gradle.kts and compare the apply* tasks when gitFilePatches is changed to true. Reproduce the failure using the reported applyMinecraft(type patch)Patches task, then compare it with the conversion in the opposite direction. Done means rebuilding successfully converts between file patches and regular git patches in both directions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git, kotlin
- Domain
- build-system, tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100