Shading reobf artifacts into userdev project jar results in issues from double remapping
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 317
- Forks
- 76
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 5
Description
When using the commandAPI shade dep the reobfJar task changes the class import of ResourceManager to IResourceManager.
The source of the class: https://github.com/JorelAli/CommandAPI/blob/master/CommandAPI/commandapi-1.18.2/src/main/java/dev/jorel/commandapi/nms/NMS_1_18_R2.java
I believe this might have something to do with that plugin being complied with the spigot nms maps.
See the two attached classes for the non reobf and then the broken reobf.
https://drive.google.com/drive/folders/1ev7YNMG7I1vG3IqkmI2iZEmTWtivNVpu?usp=sharing
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with CommandAPI/commandapi-1.18.2/src/main/java/dev/jorel/commandapi/nms/NMS_1_18_R2.java and inspect how the commandAPI shade dependency interacts with the reobfJar task. Compare the linked non-reobfuscated and broken reobfuscated classes, then verify that ResourceManager is not incorrectly remapped to IResourceManager.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100