Make GitHub login work for previews
Open
Nobody has claimed this yet.
area: diff viewer
type: feature
- Dominant language
- TypeScript
- Stars
- 50
- Forks
- 8
- Avg merge
- 1h 38m
- Merged PRs (30d)
- 6
Description
The production callback will need another parameter for the actual (preview) callback url, which will be validated and guarded by CORS. This way outside PRs can use GitHub login without having the secrets exposed.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the existing GitHub login callback and its production configuration, then inspect how preview URLs are supplied and validated. Done means an outside PR preview can use GitHub login without exposing secrets, while callback access remains guarded by CORS.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github, typescript
- Domain
- authentication, security
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100