concurrency issue with how param mappings are copied down
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 22
- Forks
- 1
- Avg merge
- 2m
- Merged PRs (30d)
- 1
Description
i.e. Tadpole#addAdditionalSaveData, Entity has it as tag, all other sub classes as compound, tadpole itself has none.
its a race whether tag or compound (correct) is used.
it seems like hypo doesn't iterate the hierarchy properly, it looks at all child methods, not only direct childs, so it can't properly stop if it encounters a mapping.
for now workaround is just disable parallism for hypo
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing Tadpole#addAdditionalSaveData and the mapping definitions on Entity, Tadpole, and its other subclasses. Inspect how hypo walks the hierarchy and copies mappings when parallelism is enabled. Done means the direct-child mapping precedence is deterministic and the reported tag-versus-compound race no longer occurs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100