PaperMC / PaperMC/Waterfall

Make MOTD follow server priorities

Open
#782 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Shell
Stars
752
Forks
307
Avg merge
15h 48m
Merged PRs (30d)
7

Description

As it is implemented currently, the MOTD ignores the settings for server fallbacks and defaults.
Ideally, the following changes to the MOTD behavior should be made for continuity with server fallback behavior:

priorities:
  - First
  - Second
servers:
  First:
    motd: 'First Server!'
    address: localhost:25564
    restricted: false
  Second:
    motd: 'Second Server!'
    address: localhost:25566
    restricted: false

if 'First' is offline the player will be connected to 'Second', so the MOTD for 'Second' should be displayed.
if all servers are offline, the player should see the MOTD of the Waterfall server.

This is in-line with the fallback behavior of the servers themselves, so it should be expected that the MOTDs would behave this way as well.

Since this behavior may not be desirable for all server owners, I suggest either tying it to the force_default_server setting since it already affects what MOTD is shown, or adding an additional setting to accomodate the change.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files or tests. Start by locating the MOTD handling and the server fallback/default-setting entry points, then compare their behavior with the two-server example. Done means the selected fallback server's MOTD is shown, while the Waterfall MOTD is used when all configured servers are offline, with the configuration choice resolved.

Written by the indexing model from the issue text.

Assessment

Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.