PaperMC / PaperMC/Waterfall

Jessica Client crashes bungee

Open
#429 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Shell
Stars
752
Forks
307
Avg merge
15h 48m
Merged PRs (30d)
7

Description

Latest jessica client's feature ".figure" crashes bungeecord quite fast (no errors, it just restarts), if there are at least 2 players online.
That feature sends item packets containing shulkerboxes that have books with oversized pages (too long and too many) inside. Seems like a workaround on the now already fixed oversized book exploit.

I think this should be prevented directly on waterfall, because only bungeecord crashes, while the spigot server is fine.

I was able to block this on spigot by checking packets via protocollib's api (viaversion and other common ways to block that kind of packet does not work sadly), but having a proper fix inside bungeecord would be better imho.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the crash using the Jessica Client’s .figure feature with at least two players online, then inspect Waterfall’s handling of item packets containing shulkerboxes with oversized book pages. Done means the proxy no longer restarts on these packets while ordinary item traffic and the backend server continue working.

Written by the indexing model from the issue text.

Assessment

Domain
networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.