PaperMC / PaperMC/Waterfall

ServerKickEvent discrepencies

Open
#419 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Shell
Stars
752
Forks
307
Avg merge
15h 48m
Merged PRs (30d)
7

Description

Waterfall improved the ServerKickEvent to cover more cases, (#39), this is great because it lets plugins capture certain situations easier than vs bungee, however;

Specifically, the LOST_CONNECTION cause is generic and fired should the client disconnect from the client, leading to a specific edge case which plugins do not expect: The client has disconnected from the server

I guess this opens a question of what is the best way to go for this:

  1. Move lost connection to its own event, this could technically also be configured to support the older way of ServerKickEvent capturing this

  2. Does a LOST_CONNECTION cause really fall under a server kick event? (Too generic vs server kick which imples that the player was actually kicked, not that we just closed the connection) (Or, would this fall into 1, maybe without backwards compat)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing ServerKickEvent, the LOST_CONNECTION cause, and the Waterfall improvement referenced as #39. Compare the two proposed approaches, including backward compatibility, and clarify which client-disconnect behavior should be represented. Done means the event semantics and compatibility decision are settled and reflected in the project.

Written by the indexing model from the issue text.

Assessment

Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.