PaperMC / PaperMC/Velocity

BungeeGuard setting breaks Forge 1.12 compatibility

Open
#710 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
2.3k
Forks
959
Avg merge
5d 10h
Merged PRs (30d)
2

Description

Steps to reproduce:

  1. Setup proxy and one modded forge backend server
  2. Set proxy to announce-forge to true, ping-passthrough "mods", and forwarding mode to "bungeeguard"
  3. Attempt to connect with BungeeGuard installed on backend server

Expected result
Successfully joining the server

Result encountered
Disconnect from backend server saying "this server requires mods"

Additional notes
WaterFall + BungeeGuard does not reproduce this error. Additional testing using VelocityGuard and setting forwarding mode to "legacy" works. My thought is that the proxy is not relaying the client mods to the server when set to "bungeeguard" mode as the client presents as a vanilla client even though mods are installed. When set to "legacy" the mod list gets passed to the backend server. The proxy is able to passthrough the mods to the client but not able to send the client mods to the backend server.

Velocity Version: 3.1.1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the failure with Velocity 3.1.1, announce-forge, ping-passthrough "mods", bungeeguard forwarding, and a Forge 1.12 backend. Compare the bungeeguard and legacy forwarding behavior, including the Waterfall and VelocityGuard observations. Done means a modded client can join the Forge backend with bungeeguard without the backend reporting that mods are required.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend, networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.