Plugin injector is in DEVELOPMENT stage
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 2.3k
- Forks
- 959
- Avg merge
- 5d 10h
- Merged PRs (30d)
- 2
Description
Since JavaPluginLoader#createPlugin doesn't provide a stage when creating the injector, it defaults to DEVELOPMENT (see the guice docs).
I think it should default to PRODUCTION and should be a command line or configuration option. The stage is important as it affects how singletons are initialised.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with JavaPluginLoader#createPlugin in proxy/src/main/java/com/velocitypowered/proxy/plugin/loader/java/JavaPluginLoader.java at the linked line, then read the referenced Guice createInjector documentation and singleton preloading notes. Determine how the injector stage should default and how a command-line or configuration option would expose it; done means the stage is production by default and can be configured.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100