Rework server disconnect logic
Open
Nobody has claimed this yet.
type: feature
- Dominant language
- Java
- Stars
- 2.3k
- Forks
- 960
- Avg merge
- 5d 10h
- Merged PRs (30d)
- 2
Description
This is also one of my least favorite parts of the Velocity codebase so far. The server (re)connection logic is very poorly structured and even though I wrote the code I still can't quite understand how it works. It needs a rewrite (paired with the new event API ala #378).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files, tests, or entry points. Start by reading the server reconnection logic in the Velocity codebase and issue #378, then map how the current disconnect and reconnect paths relate to the new event API. Done means the connection logic has been rewritten in that paired scope, but the issue provides no more specific acceptance criteria.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend, networking
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100