PaperMC / PaperMC/Velocity

Add new setting to prevent connected player errors in console

Open
#1,707 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type: feature
Dominant language
Java
Stars
2.3k
Forks
959
Avg merge
5d 10h
Merged PRs (30d)
2

Description

Requested Feature

Add a new config option to disable the error message when a connected player cannot connect.

https://github.com/PaperMC/Velocity/blob/372a3b28bd3bbaebf5934b4582dbb2feba70a93e/proxy/src/main/java/com/velocitypowered/proxy/connection/client/ConnectedPlayer.java#L718

Why is this needed?

Especially on big servers, the red error messages can spam the console, even when player connection messages are disabled (there is already a setting for logging connection messages)

Alternative Solutions
  • don’t add a new setting and only add the config check for the log-player-connections boolean
  • ignore these messages in console, wich can be very annoying or even confusing
Additional Information

The error is send here: https://github.com/PaperMC/Velocity/blob/372a3b28bd3bbaebf5934b4582dbb2feba70a93e/proxy/src/main/java/com/velocitypowered/proxy/connection/client/ConnectedPlayer.java#L718

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at proxy/src/main/java/com/velocitypowered/proxy/connection/client/ConnectedPlayer.java around line 718 and inspect how the existing log-player-connections setting is handled. Determine whether to reuse that setting or add a separate option, then verify that disabled logging prevents the connected-player error from appearing in the console.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.